Re: [PATCH] fortran/67802 -- Numeric constant character length must ...

2015-10-01 Thread Steve Kargl
On Thu, Oct 01, 2015 at 11:19:37PM +0200, Dominique d'Humières wrote: > Without initialization the errors are of the kind: > > Error: Expression at (1) must be of INTEGER type, found * > > see https://gcc.gnu.org/ml/gcc-bugs/2015-10/msg00081.html. Should not we get > the same message with initia

Re: [PATCH] fortran/67802 -- Numeric constant character length must ...

2015-10-01 Thread Dominique d'Humières
Without initialization the errors are of the kind: Error: Expression at (1) must be of INTEGER type, found * see https://gcc.gnu.org/ml/gcc-bugs/2015-10/msg00081.html. Should not we get the same message with initialization? Cheers, Dominique

Re: [PATCH] fortran/67802 -- Numeric constant character length must ...

2015-10-01 Thread FX
> Well, ahem, gfortran does have several error messages that use the > standard notation. I know. I wrote some of them. :-) > > I'll simply change it to "Expecting an INTEGER at %L” Thanks. I have no objections to using the full standard terminology (scalar integer expression), but not the sho

Re: [PATCH] fortran/67802 -- Numeric constant character length must ...

2015-10-01 Thread Steve Kargl
On Thu, Oct 01, 2015 at 09:19:15PM +0200, FX wrote: > > 2015-10-01 Steven G. Kargl > > > > PR fortran/67802 > > * decl.c (add_init_expr_to_sym): Numeric constant for character > > length must be an INTEGER. > > > > 2015-10-01 Steven G. Kargl > > > > PR fortran/67802 > >

Re: [PATCH] fortran/67802 -- Numeric constant character length must ...

2015-10-01 Thread FX
> 2015-10-01 Steven G. Kargl > > PR fortran/67802 > * decl.c (add_init_expr_to_sym): Numeric constant for character > length must be an INTEGER. > > 2015-10-01 Steven G. Kargl > > PR fortran/67802 > * gfortran.dg/pr67802.f90: New test. OK, but not with that e

[PATCH] fortran/67802 -- Numeric constant character length must ...

2015-10-01 Thread Steve Kargl
be an integer expression. The attached patch checks that a numerical constant in a CHARACTER(LEN=x) declaration is an integer. Regression tested on x86_64-*-freebsd*. OK to commit? 2015-10-01 Steven G. Kargl PR fortran/67802 * decl.c (add_init_expr_to_sym): Numeric constant