Re: [PATCH] gcc/c-family/c-cppbuiltin.c: Use 20 instead of 18 for the maximized 64-bits integer decimal string length

2014-11-20 Thread Joseph Myers
On Thu, 20 Nov 2014, Chen Gang wrote: OK, thanks. I guess your meaning is: - If the value is small enough to be expressed by type 'int', we should not provide 'LL'. Yes - and values not small enough should probably not be accepted by this function. - If the value is positive number,

Re: [PATCH] gcc/c-family/c-cppbuiltin.c: Use 20 instead of 18 for the maximized 64-bits integer decimal string length

2014-11-20 Thread Chen Gang
OK, thank you for your details description. I shall send patch v2 for it, within this week. Send from Lenovo A788t. Joseph Myers jos...@codesourcery.com wrote: On Thu, 20 Nov 2014, Chen Gang wrote: OK, thanks. I guess your meaning is: - If the value is small enough to be expressed by

Re: [PATCH] gcc/c-family/c-cppbuiltin.c: Use 20 instead of 18 for the maximized 64-bits integer decimal string length

2014-11-19 Thread Joseph Myers
On Wed, 19 Nov 2014, Chen Gang wrote: OK, thanks, what you said sounds reasonable to me. We need '(' and ')' for negative members, and LL for the members which is larger than 32 bits. I don't think LL is a good idea when not needed - quite possibly some of the macros are expected or required

Re: [PATCH] gcc/c-family/c-cppbuiltin.c: Use 20 instead of 18 for the maximized 64-bits integer decimal string length

2014-11-19 Thread Chen Gang
On 11/20/14 1:20, Joseph Myers wrote: On Wed, 19 Nov 2014, Chen Gang wrote: OK, thanks, what you said sounds reasonable to me. We need '(' and ')' for negative members, and LL for the members which is larger than 32 bits. I don't think LL is a good idea when not needed - quite possibly

Re: [PATCH] gcc/c-family/c-cppbuiltin.c: Use 20 instead of 18 for the maximized 64-bits integer decimal string length

2014-11-18 Thread Joseph Myers
On Sun, 16 Nov 2014, Chen Gang wrote: The maximize 64-bits integer decimal string length excluding NUL is 20 ( '-9223372036854775808'), so need use 20 instead of 18 for HOST_WIDE_INT. 2014-11-16 Chen Gang gang.chen.5...@gmail.com * c-family/c-cppbuiltin.c

Re: [PATCH] gcc/c-family/c-cppbuiltin.c: Use 20 instead of 18 for the maximized 64-bits integer decimal string length

2014-11-18 Thread Chen Gang
On 11/19/14 0:44, Joseph Myers wrote: On Sun, 16 Nov 2014, Chen Gang wrote: The maximize 64-bits integer decimal string length excluding NUL is 20 ( '-9223372036854775808'), so need use 20 instead of 18 for HOST_WIDE_INT. 2014-11-16 Chen Gang gang.chen.5...@gmail.com *

Re: [PATCH] gcc/c-family/c-cppbuiltin.c: Use 20 instead of 18 for the maximized 64-bits integer decimal string length

2014-11-18 Thread Chen Gang
On 11/19/14 11:03, Chen Gang wrote: On 11/19/14 0:44, Joseph Myers wrote: On Sun, 16 Nov 2014, Chen Gang wrote: The maximize 64-bits integer decimal string length excluding NUL is 20 ( '-9223372036854775808'), so need use 20 instead of 18 for HOST_WIDE_INT. 2014-11-16 Chen Gang

[PATCH] gcc/c-family/c-cppbuiltin.c: Use 20 instead of 18 for the maximized 64-bits integer decimal string length

2014-11-16 Thread Chen Gang
The maximize 64-bits integer decimal string length excluding NUL is 20 ( '-9223372036854775808'), so need use 20 instead of 18 for HOST_WIDE_INT. 2014-11-16 Chen Gang gang.chen.5...@gmail.com * c-family/c-cppbuiltin.c (builtin_define_with_int_value): Use 20 instead of 18 for