Re: [PATCH] gcc/configure.ac: fix register issue for global_load assembler functions

2021-06-17 Thread Joseph Myers
On Thu, 17 Jun 2021, Marcel Vollweiler wrote: > Thank you for your proposals. I adapted configure.ac and gcn.c > accordingly (similar to the GATHER_STATISTICS example). Thanks, the configure changes in this version are OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] gcc/configure.ac: fix register issue for global_load assembler functions

2021-06-17 Thread Marcel Vollweiler
Am 16.06.2021 um 19:19 schrieb Joseph Myers: On Wed, 16 Jun 2021, Julian Brown wrote: +if test x$gcc_cv_as_gcn_global_load_fixed = xyes; then + AC_DEFINE(HAVE_GCN_ASM_GLOBAL_LOAD_FIXED, 1, [Define if your assembler has fixed global_load functions.]) +else +

Re: [PATCH] gcc/configure.ac: fix register issue for global_load assembler functions

2021-06-16 Thread Joseph Myers
On Wed, 16 Jun 2021, Julian Brown wrote: > > +if test x$gcc_cv_as_gcn_global_load_fixed = xyes; then > > + AC_DEFINE(HAVE_GCN_ASM_GLOBAL_LOAD_FIXED, 1, [Define if your > > assembler has fixed global_load functions.]) > > +else > > + AC_DEFINE(HAVE_GCN_ASM_GLOBAL_LOAD_FIXED, 0,

Re: [PATCH] gcc/configure.ac: fix register issue for global_load assembler functions

2021-06-16 Thread Julian Brown
At the risk of overstepping my GCN backend review remit... On Wed, 16 Jun 2021 11:34:53 +0200 Marcel Vollweiler wrote: > index d9fc3c2..e179ce1 100644 > --- a/gcc/configure.ac > +++ b/gcc/configure.ac > @@ -5357,6 +5357,30 @@ case "$target" in > ;; > esac > > +# This tests if the

Re: [PATCH] gcc/configure.ac: fix register issue for global_load assembler functions

2021-06-16 Thread Marcel Vollweiler
Changed the variable "gcc_cv_as_global_load_fixed" into "gcc_cv_as_gcn_global_load_fixed" in order to have the "gcn" substring also in the config.patch file. Am 09.06.2021 um 16:47 schrieb Marcel Vollweiler: This patch fixes an issue with global_load assembler functions leading to a "invalid

Re: [PATCH] gcc/configure.ac: fix register issue for global_load assembler functions

2021-06-14 Thread Julian Brown
On Mon, 14 Jun 2021 13:36:54 +0100 Julian Brown wrote: > On Wed, 9 Jun 2021 16:47:21 +0200 > Marcel Vollweiler wrote: > > In this patch a compatibility check is added to the configure.ac. > > The implementation of the solution looks fine, but I worry it's the > wrong approach. What would

Re: [PATCH] gcc/configure.ac: fix register issue for global_load assembler functions

2021-06-14 Thread Andrew Stubbs
On 14/06/2021 13:36, Julian Brown wrote: On Wed, 9 Jun 2021 16:47:21 +0200 Marcel Vollweiler wrote: This patch fixes an issue with global_load assembler functions leading to a "invalid operand for instruction" error since in different LLVM versions those functions use either one or two

Re: [PATCH] gcc/configure.ac: fix register issue for global_load assembler functions

2021-06-14 Thread Tobias Burnus
On 14.06.21 14:36, Julian Brown wrote: On Wed, 9 Jun 2021 16:47:21 +0200 Marcel Vollweiler wrote: This patch fixes an issue with global_load assembler functions leading to a "invalid operand for instruction" error since in different LLVM versions those functions use either one or two

Re: [PATCH] gcc/configure.ac: fix register issue for global_load assembler functions

2021-06-14 Thread Julian Brown
On Wed, 9 Jun 2021 16:47:21 +0200 Marcel Vollweiler wrote: > This patch fixes an issue with global_load assembler functions leading > to a "invalid operand for instruction" error since in different LLVM > versions those functions use either one or two registers. LLVM is neither forward- nor

[PATCH] gcc/configure.ac: fix register issue for global_load assembler functions

2021-06-09 Thread Marcel Vollweiler
This patch fixes an issue with global_load assembler functions leading to a "invalid operand for instruction" error since in different LLVM versions those functions use either one or two registers. In this patch a compatibility check is added to the configure.ac. Marcel - Mentor