Re: [PATCH] gcc/riscv: Correctly ignore empty C++ structs when flattening for ABI

2019-03-13 Thread Jim Wilson
On Wed, Mar 13, 2019 at 11:39 AM Andrew Burgess wrote: > gcc/ChangeLog: > > PR target/89627 > * config/riscv/riscv.c (riscv_pass_fpr_single): Add offset > parameter, and make use of it. > (riscv_get_arg_info): Pass offset to riscv_pass_fpr_single. > >

Re: [PATCH] gcc/riscv: Correctly ignore empty C++ structs when flattening for ABI

2019-03-13 Thread Jim Wilson
On Wed, Mar 13, 2019 at 11:53 AM Andrew Pinski wrote: > This testcase seems generic, that is it has no ABI dependent values > attached to it. > Can it be moved to a more generic location instead? Maybe there are > other targets which get this incorrect also. I'm not aware of any other target

Re: [PATCH] gcc/riscv: Correctly ignore empty C++ structs when flattening for ABI

2019-03-13 Thread Andrew Pinski
On Wed, Mar 13, 2019 at 11:40 AM Andrew Burgess wrote: > > Jim, > > Sorry for the delay in sending this patch. > > Thanks, > Andrew > > --- > > This fixes PR target/89627. > > The RISC-V ABI document[1] says: > >For the purposes of this section, "struct" refers to a C struct >with its

[PATCH] gcc/riscv: Correctly ignore empty C++ structs when flattening for ABI

2019-03-13 Thread Andrew Burgess
Jim, Sorry for the delay in sending this patch. Thanks, Andrew --- This fixes PR target/89627. The RISC-V ABI document[1] says: For the purposes of this section, "struct" refers to a C struct with its hierarchy flattened, including any array fields. That is, struct { struct { float