Re: [PATCH] gcov-profile: Fix -fcompare-debug with -fprofile-generate [PR100520]

2021-11-08 Thread Richard Biener via Gcc-patches
On Mon, Nov 8, 2021 at 12:01 PM Jan Hubicka via Gcc-patches wrote: > > > On 11/5/21 18:30, Jan Hubicka wrote: > > > every gcc source looks like bit of overkill given that is can be open > > > coded in 3 statements? > > > > Why? It's a static inline function with few statements. I don't want to >

Re: [PATCH] gcov-profile: Fix -fcompare-debug with -fprofile-generate [PR100520]

2021-11-08 Thread Jan Hubicka via Gcc-patches
> On 11/5/21 18:30, Jan Hubicka wrote: > > every gcc source looks like bit of overkill given that is can be open > > coded in 3 statements? > > Why? It's a static inline function with few statements. I don't want to > copy > the same code at every location. I bet there must quite some open-coded

Re: [PATCH] gcov-profile: Fix -fcompare-debug with -fprofile-generate [PR100520]

2021-11-08 Thread Martin Liška
On 11/5/21 18:30, Jan Hubicka wrote: every gcc source looks like bit of overkill given that is can be open coded in 3 statements? Why? It's a static inline function with few statements. I don't want to copy the same code at every location. I bet there must quite some open-coded

Re: [PATCH] gcov-profile: Fix -fcompare-debug with -fprofile-generate [PR100520]

2021-11-05 Thread Jan Hubicka via Gcc-patches
> Hello. > > This strips .gk from aux_base_name in coverage.c. > Do you like the implementation of endswith, or do we have the functionality > somewhere? > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > PR

[PATCH] gcov-profile: Fix -fcompare-debug with -fprofile-generate [PR100520]

2021-11-05 Thread Martin Liška
Hello. This strips .gk from aux_base_name in coverage.c. Do you like the implementation of endswith, or do we have the functionality somewhere? Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin PR gcov-profile/100520