Re: [PATCH] gotools: Workaround non-reproduceability of automake

2024-04-16 Thread Jakub Jelinek
On Mon, Apr 15, 2024 at 10:30:15PM +0200, Jakub Jelinek wrote: > On Mon, Apr 15, 2024 at 04:20:16PM -0400, Eric Gallager wrote: > > > I'm not familiar with automake/m4 enough to debug that, so I'm > > > instead offering a workaround, with this patch the order is deterministic. > > > > Is there a b

Re: [PATCH] gotools: Workaround non-reproduceability of automake

2024-04-15 Thread Jakub Jelinek
On Mon, Apr 15, 2024 at 04:20:16PM -0400, Eric Gallager wrote: > > I'm not familiar with automake/m4 enough to debug that, so I'm > > instead offering a workaround, with this patch the order is deterministic. > > Is there a bug open with automake upstream for this? No, feel free to file it.

Re: [PATCH] gotools: Workaround non-reproduceability of automake

2024-04-15 Thread Eric Gallager
On Mon, Apr 15, 2024 at 8:43 AM Jakub Jelinek wrote: > > Hi! > > The regen bot recently flagged a difference in gotools/Makefile.in. > Trying it locally, it seems pretty random > for i in `seq 20`; do PATH=~/automake-1.15.1/bin:~/autoconf-2.69/bin:$PATH > automake; echo -n `git diff Makefile.in |

Re: [PATCH] gotools: Workaround non-reproduceability of automake

2024-04-15 Thread Ian Lance Taylor
On Mon, Apr 15, 2024 at 5:42 AM Jakub Jelinek wrote: > > 2024-04-15 Jakub Jelinek > > * Makefile.am (install-exec-local, uninstall-local): Add goals > on the else branch of if NATIVE to ensure reproducibility. > * Makefile.in: Regenerate. This is OK. Go ahead and commi

[PATCH] gotools: Workaround non-reproduceability of automake

2024-04-15 Thread Jakub Jelinek
Hi! The regen bot recently flagged a difference in gotools/Makefile.in. Trying it locally, it seems pretty random for i in `seq 20`; do PATH=~/automake-1.15.1/bin:~/autoconf-2.69/bin:$PATH automake; echo -n `git diff Makefile.in | wc -l`" "; done; echo; for i in `seq 20`; do PATH=~/automake-1.15