Re: [PATCH] handle multibyte stores larger than char in strlen (PR 91183, 86888)

2019-07-25 Thread Jeff Law
On 7/25/19 1:42 PM, Martin Sebor wrote: > On 7/24/19 8:39 PM, Jeff Law wrote: >> On 7/24/19 8:17 PM, Martin Sebor wrote: Committed in r273783 after retesting and including a test for the warning that I had left out of the patch I posted here. Martin PS I suspect some

Re: [PATCH] handle multibyte stores larger than char in strlen (PR 91183, 86888)

2019-07-25 Thread Martin Sebor
On 7/24/19 8:39 PM, Jeff Law wrote: On 7/24/19 8:17 PM, Martin Sebor wrote: Committed in r273783 after retesting and including a test for the warning that I had left out of the patch I posted here. Martin PS I suspect some of the tests I added might need tweaking on big-endian systems.  I'll

Re: [PATCH] handle multibyte stores larger than char in strlen (PR 91183, 86888)

2019-07-24 Thread Jeff Law
On 7/24/19 8:17 PM, Martin Sebor wrote: >> Committed in r273783 after retesting and including a test for >> the warning that I had left out of the patch I posted here. >> >> Martin >> >> PS I suspect some of the tests I added might need tweaking on >> big-endian systems.  I'll deal with them

Re: [PATCH] handle multibyte stores larger than char in strlen (PR 91183, 86888)

2019-07-24 Thread Jeff Law
On 7/24/19 8:17 PM, Martin Sebor wrote: >> Committed in r273783 after retesting and including a test for >> the warning that I had left out of the patch I posted here. >> >> Martin >> >> PS I suspect some of the tests I added might need tweaking on >> big-endian systems.  I'll deal with them

Re: [PATCH] handle multibyte stores larger than char in strlen (PR 91183, 86888)

2019-07-24 Thread Martin Sebor
Committed in r273783 after retesting and including a test for the warning that I had left out of the patch I posted here. Martin PS I suspect some of the tests I added might need tweaking on big-endian systems.  I'll deal with them tomorrow. And maybe also strictly aligned targets. A

Re: [PATCH] handle multibyte stores larger than char in strlen (PR 91183, 86888)

2019-07-24 Thread Martin Sebor
On 7/24/19 11:06 AM, Jeff Law wrote: On 7/22/19 5:17 PM, Martin Sebor wrote: Umm "store_b4_nul"?  Are you really trying to save 3 characters in the name by writing it this way?  :-) I'm actually saving four characters over "store_before_nul" ;-) :-) It's just a name I picked because I

Re: [PATCH] handle multibyte stores larger than char in strlen (PR 91183, 86888)

2019-07-24 Thread Jeff Law
On 7/22/19 5:17 PM, Martin Sebor wrote: >> Umm "store_b4_nul"?  Are you really trying to save 3 characters in the >> name by writing it this way?  :-) > > I'm actually saving four characters over "store_before_nul" ;-) :-) > > It's just a name I picked because I like it.  Would you prefer to >

Re: [PATCH] handle multibyte stores larger than char in strlen (PR 91183, 86888)

2019-07-22 Thread Martin Sebor
On 7/22/19 3:33 PM, Jeff Law wrote: On 7/19/19 4:04 PM, Martin Sebor wrote: On targets with permissive alignment requirements GCC sometimes lowers stores of short (between two and 16 bytes), power-of-two char sequences  to single integer stores of the corresponding width.  This happens for 

Re: [PATCH] handle multibyte stores larger than char in strlen (PR 91183, 86888)

2019-07-22 Thread Jeff Law
On 7/19/19 4:04 PM, Martin Sebor wrote: > On targets with permissive alignment requirements GCC sometimes > lowers stores of short (between two and 16 bytes), power-of-two > char sequences  to single integer stores of the corresponding > width.  This happens for sequences of ordinary character 

[PATCH] handle multibyte stores larger than char in strlen (PR 91183, 86888)

2019-07-19 Thread Martin Sebor
On targets with permissive alignment requirements GCC sometimes lowers stores of short (between two and 16 bytes), power-of-two char sequences to single integer stores of the corresponding width. This happens for sequences of ordinary character stores as well as for some calls to memcpy.