Re: [PATCH] i386: Fix up -fdollars-in-identifiers with identifiers starting with $ in -masm=att (PR target/91298)

2020-01-26 Thread Rainer Orth
Hi Jakub, > On Thu, Jan 23, 2020 at 09:19:52PM +0100, Rainer Orth wrote: >> Unlikely: there's barely any development on the Solaris assemblers these >> days, though I prefer to xfail tests if possible to get notified if they >> suddenly start to work for some reason. > > Ok. here's what I've inst

Re: [PATCH] i386: Fix up -fdollars-in-identifiers with identifiers starting with $ in -masm=att (PR target/91298)

2020-01-23 Thread Jakub Jelinek
On Thu, Jan 23, 2020 at 09:19:52PM +0100, Rainer Orth wrote: > Unlikely: there's barely any development on the Solaris assemblers these > days, though I prefer to xfail tests if possible to get notified if they > suddenly start to work for some reason. Ok. Jakub

Re: [PATCH] i386: Fix up -fdollars-in-identifiers with identifiers starting with $ in -masm=att (PR target/91298)

2020-01-23 Thread Rainer Orth
Hi Jakub, > On Thu, Jan 23, 2020 at 09:12:27PM +0100, Rainer Orth wrote: >> +FAIL: gcc.target/i386/pr91298-2.c (test for excess errors) >> >> It only allows letters, digits, '_' and '.' in identifiers: >> https://docs.oracle.com/cd/E37838_01/html/E61064/eqbsx.html#XALRMeoqjw > > So, no way to emi

Re: [PATCH] i386: Fix up -fdollars-in-identifiers with identifiers starting with $ in -masm=att (PR target/91298)

2020-01-23 Thread Jakub Jelinek
On Thu, Jan 23, 2020 at 09:12:27PM +0100, Rainer Orth wrote: > +FAIL: gcc.target/i386/pr91298-2.c (test for excess errors) > > It only allows letters, digits, '_' and '.' in identifiers: > https://docs.oracle.com/cd/E37838_01/html/E61064/eqbsx.html#XALRMeoqjw So, no way to emit other letters in i

Re: [PATCH] i386: Fix up -fdollars-in-identifiers with identifiers starting with $ in -masm=att (PR target/91298)

2020-01-23 Thread Rainer Orth
Hi Jakub, > In AT&T syntax leading $ is special, so if we have identifiers that start > with dollar, we usually fail to assemble it (or assemble incorrectly). > As mentioned in the PR, what works is wrapping the identifiers inside of > parens, like: > movl$($a), %eax > leaq($a)

Re: [PATCH] i386: Fix up -fdollars-in-identifiers with identifiers starting with $ in -masm=att (PR target/91298)

2020-01-18 Thread Uros Bizjak
On Sat, Jan 18, 2020 at 1:30 PM Jakub Jelinek wrote: > > Hi! > > In AT&T syntax leading $ is special, so if we have identifiers that start > with dollar, we usually fail to assemble it (or assemble incorrectly). > As mentioned in the PR, what works is wrapping the identifiers inside of > parens, l

[PATCH] i386: Fix up -fdollars-in-identifiers with identifiers starting with $ in -masm=att (PR target/91298)

2020-01-18 Thread Jakub Jelinek
Hi! In AT&T syntax leading $ is special, so if we have identifiers that start with dollar, we usually fail to assemble it (or assemble incorrectly). As mentioned in the PR, what works is wrapping the identifiers inside of parens, like: movl$($a), %eax leaq($a)(,%rdi,4), %ra