Re: [PATCH] i386: support micro-levels in target{, _clone} attrs [PR101696]

2021-09-13 Thread Uros Bizjak via Gcc-patches
On Thu, Aug 12, 2021 at 5:32 PM Martin Liška wrote: > > On 8/12/21 5:26 PM, H.J. Lu wrote: > > Will it hurt if they have proper feature_priorities you added? > > No. They are unused, by we should use the proper priorities. gcc/ChangeLog: * common/config/i386/cpuinfo.h (cpu_indicator_init): Add s

Re: [PATCH] i386: support micro-levels in target{,_clone} attrs [PR101696]

2021-09-13 Thread Martin Liška
PING^1 On 8/13/21 15:41, H.J. Lu wrote: On Fri, Aug 13, 2021 at 1:10 AM Martin Liška wrote: On 8/12/21 7:35 PM, H.J. Lu wrote: What happens for arch=x86-64-v5? pr101696.c:5:55: error: bad value (‘x86-64-v5’) for ‘target("arch=")’ attribute 5 | __attribute__ ((target ("arch=x86-64-v5

Re: [PATCH] i386: support micro-levels in target{, _clone} attrs [PR101696]

2021-08-13 Thread H.J. Lu via Gcc-patches
On Fri, Aug 13, 2021 at 1:10 AM Martin Liška wrote: > > On 8/12/21 7:35 PM, H.J. Lu wrote: > > What happens for arch=x86-64-v5? > > pr101696.c:5:55: error: bad value (‘x86-64-v5’) for ‘target("arch=")’ > attribute > > 5 | __attribute__ ((target ("arch=x86-64-v5"))) void foo () { > __builti

Re: [PATCH] i386: support micro-levels in target{,_clone} attrs [PR101696]

2021-08-13 Thread Martin Liška
On 8/12/21 7:35 PM, H.J. Lu wrote: What happens for arch=x86-64-v5? pr101696.c:5:55: error: bad value (‘x86-64-v5’) for ‘target("arch=")’ attribute 5 | __attribute__ ((target ("arch=x86-64-v5"))) void foo () { __builtin_printf ("arch=x86-64-v4\n"); } |

Re: [PATCH] i386: support micro-levels in target{, _clone} attrs [PR101696]

2021-08-12 Thread H.J. Lu via Gcc-patches
On Thu, Aug 12, 2021 at 8:31 AM Martin Liška wrote: > > On 8/12/21 5:26 PM, H.J. Lu wrote: > > Will it hurt if they have proper feature_priorities you added? > > No. They are unused, by we should use the proper priorities. > > Martin + const char *arch_name = attrs_str + strlen ("arch="); +

Re: [PATCH] i386: support micro-levels in target{,_clone} attrs [PR101696]

2021-08-12 Thread Martin Liška
:43 +0200 Subject: [PATCH] i386: support micro-levels in target{,_clone} attrs [PR101696] As mentioned in the PR, we do miss supports target micro-architectures in target and target_clone attribute. While the levels x86-64 x86-64-v2 x86-64-v3 x86-64-v4 are supported values by -march option, they

Re: [PATCH] i386: support micro-levels in target{, _clone} attrs [PR101696]

2021-08-12 Thread H.J. Lu via Gcc-patches
On Thu, Aug 12, 2021 at 8:22 AM Martin Liška wrote: > > On 8/12/21 4:51 PM, H.J. Lu wrote: > > On Thu, Aug 12, 2021 at 7:39 AM Martin Liška wrote: > >> > >> On 8/12/21 4:25 PM, H.J. Lu wrote: > >>> Please send out the v2 patch with the enclosed patch. I added some tests. > >> > >> Thanks, there'

Re: [PATCH] i386: support micro-levels in target{,_clone} attrs [PR101696]

2021-08-12 Thread Martin Liška
On 8/12/21 4:51 PM, H.J. Lu wrote: On Thu, Aug 12, 2021 at 7:39 AM Martin Liška wrote: On 8/12/21 4:25 PM, H.J. Lu wrote: Please send out the v2 patch with the enclosed patch. I added some tests. Thanks, there's patch which includes your changes. Martin diff --git a/gcc/common/config/i3

Re: [PATCH] i386: support micro-levels in target{, _clone} attrs [PR101696]

2021-08-12 Thread H.J. Lu via Gcc-patches
On Thu, Aug 12, 2021 at 7:39 AM Martin Liška wrote: > > On 8/12/21 4:25 PM, H.J. Lu wrote: > > Please send out the v2 patch with the enclosed patch. I added some tests. > > Thanks, there's patch which includes your changes. > > Martin diff --git a/gcc/common/config/i386/i386-isas.h b/gcc/common/

Re: [PATCH] i386: support micro-levels in target{,_clone} attrs [PR101696]

2021-08-12 Thread Martin Liška
15:20:43 +0200 Subject: [PATCH] i386: support micro-levels in target{,_clone} attrs [PR101696] As mentioned in the PR, we do miss supports target micro-architectures in target and target_clone attribute. While the levels x86-64 x86-64-v2 x86-64-v3 x86-64-v4 are supported values by -march option,

Re: [PATCH] i386: support micro-levels in target{, _clone} attrs [PR101696]

2021-08-12 Thread H.J. Lu via Gcc-patches
On Thu, Aug 12, 2021 at 7:12 AM Martin Liška wrote: > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > I modified the H.J. patch draft. Please send out the v2 patch with the enclosed patch. I added some tests. > @H.J. Can you please verify the newly added 'feature_prio

[PATCH] i386: support micro-levels in target{,_clone} attrs [PR101696]

2021-08-12 Thread Martin Liška
Patch can bootstrap on x86_64-linux-gnu and survives regression tests. I modified the H.J. patch draft. @H.J. Can you please verify the newly added 'feature_priority'? As mentioned in the PR, we do miss supports target micro-architectures in target and target_clone attribute. While the levels x86