Re: [PATCH] include size and offset in -Wstringop-overflow

2019-12-11 Thread Martin Sebor
On 12/5/19 4:37 PM, Martin Sebor wrote: If yes, since I don't think I have the time for it for GCC 10 I need to decide whether to drop just this improvement or all of the buffer overflow checks that depend on it. Let me know which you prefer. As I mentioned in my previous message, I think we've

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-12-05 Thread Martin Sebor
If yes, since I don't think I have the time for it for GCC 10 I need to decide whether to drop just this improvement or all of the buffer overflow checks that depend on it. Let me know which you prefer. As I mentioned in my previous message, I think we've got two potential paths.  We could just

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-20 Thread Jeff Law
On 11/18/19 9:15 AM, Martin Sebor wrote: > On 11/17/19 12:03 PM, Jeff Law wrote: >> On 11/12/19 12:55 PM, Martin Sebor wrote: >>> On 11/12/19 10:54 AM, Jeff Law wrote: On 11/12/19 1:15 AM, Richard Biener wrote: > On Tue, Nov 12, 2019 at 6:10 AM Jeff Law wrote: >> >> On 11/6/19 3:3

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-18 Thread Martin Sebor
On 11/17/19 12:03 PM, Jeff Law wrote: On 11/12/19 12:55 PM, Martin Sebor wrote: On 11/12/19 10:54 AM, Jeff Law wrote: On 11/12/19 1:15 AM, Richard Biener wrote: On Tue, Nov 12, 2019 at 6:10 AM Jeff Law wrote: On 11/6/19 3:34 PM, Martin Sebor wrote: On 11/6/19 2:06 PM, Martin Sebor wrote:

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-17 Thread Jeff Law
On 11/12/19 1:16 AM, Richard Biener wrote: > On Tue, Nov 12, 2019 at 9:15 AM Richard Biener > wrote: >> >> On Tue, Nov 12, 2019 at 6:10 AM Jeff Law wrote: >>> >>> On 11/6/19 3:34 PM, Martin Sebor wrote: On 11/6/19 2:06 PM, Martin Sebor wrote: > On 11/6/19 1:39 PM, Jeff Law wrote: >>

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-17 Thread Jeff Law
On 11/12/19 12:55 PM, Martin Sebor wrote: > On 11/12/19 10:54 AM, Jeff Law wrote: >> On 11/12/19 1:15 AM, Richard Biener wrote: >>> On Tue, Nov 12, 2019 at 6:10 AM Jeff Law wrote: On 11/6/19 3:34 PM, Martin Sebor wrote: > On 11/6/19 2:06 PM, Martin Sebor wrote: >> On 11/6/19 1:39

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-17 Thread Jeff Law
On 11/13/19 7:34 AM, Richard Biener wrote: > On Tue, Nov 12, 2019 at 6:55 PM Jeff Law wrote: >> >> On 11/12/19 1:15 AM, Richard Biener wrote: >>> On Tue, Nov 12, 2019 at 6:10 AM Jeff Law wrote: On 11/6/19 3:34 PM, Martin Sebor wrote: > On 11/6/19 2:06 PM, Martin Sebor wrote: >>

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-13 Thread Richard Biener
On Tue, Nov 12, 2019 at 6:55 PM Jeff Law wrote: > > On 11/12/19 1:15 AM, Richard Biener wrote: > > On Tue, Nov 12, 2019 at 6:10 AM Jeff Law wrote: > >> > >> On 11/6/19 3:34 PM, Martin Sebor wrote: > >>> On 11/6/19 2:06 PM, Martin Sebor wrote: > On 11/6/19 1:39 PM, Jeff Law wrote: > > On

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-12 Thread Martin Sebor
On 11/12/19 10:54 AM, Jeff Law wrote: On 11/12/19 1:15 AM, Richard Biener wrote: On Tue, Nov 12, 2019 at 6:10 AM Jeff Law wrote: On 11/6/19 3:34 PM, Martin Sebor wrote: On 11/6/19 2:06 PM, Martin Sebor wrote: On 11/6/19 1:39 PM, Jeff Law wrote: On 11/6/19 1:27 PM, Martin Sebor wrote: On 1

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-12 Thread Jeff Law
On 11/12/19 1:15 AM, Richard Biener wrote: > On Tue, Nov 12, 2019 at 6:10 AM Jeff Law wrote: >> >> On 11/6/19 3:34 PM, Martin Sebor wrote: >>> On 11/6/19 2:06 PM, Martin Sebor wrote: On 11/6/19 1:39 PM, Jeff Law wrote: > On 11/6/19 1:27 PM, Martin Sebor wrote: >> On 11/6/19 11:55 AM,

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-12 Thread Martin Sebor
On 11/11/19 10:10 PM, Jeff Law wrote: On 11/6/19 3:34 PM, Martin Sebor wrote: On 11/6/19 2:06 PM, Martin Sebor wrote: On 11/6/19 1:39 PM, Jeff Law wrote: On 11/6/19 1:27 PM, Martin Sebor wrote: On 11/6/19 11:55 AM, Jeff Law wrote: On 11/6/19 11:00 AM, Martin Sebor wrote: The -Wstringop-over

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-12 Thread Richard Biener
On Tue, Nov 12, 2019 at 6:10 AM Jeff Law wrote: > > On 11/6/19 3:34 PM, Martin Sebor wrote: > > On 11/6/19 2:06 PM, Martin Sebor wrote: > >> On 11/6/19 1:39 PM, Jeff Law wrote: > >>> On 11/6/19 1:27 PM, Martin Sebor wrote: > On 11/6/19 11:55 AM, Jeff Law wrote: > > On 11/6/19 11:00 AM, Ma

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-12 Thread Richard Biener
On Tue, Nov 12, 2019 at 9:15 AM Richard Biener wrote: > > On Tue, Nov 12, 2019 at 6:10 AM Jeff Law wrote: > > > > On 11/6/19 3:34 PM, Martin Sebor wrote: > > > On 11/6/19 2:06 PM, Martin Sebor wrote: > > >> On 11/6/19 1:39 PM, Jeff Law wrote: > > >>> On 11/6/19 1:27 PM, Martin Sebor wrote: > > >>

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-11 Thread Jeff Law
On 11/6/19 3:34 PM, Martin Sebor wrote: > On 11/6/19 2:06 PM, Martin Sebor wrote: >> On 11/6/19 1:39 PM, Jeff Law wrote: >>> On 11/6/19 1:27 PM, Martin Sebor wrote: On 11/6/19 11:55 AM, Jeff Law wrote: > On 11/6/19 11:00 AM, Martin Sebor wrote: >> The -Wstringop-overflow warnings for s

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-11 Thread Jeff Law
On 11/6/19 2:06 PM, Martin Sebor wrote: > On 11/6/19 1:39 PM, Jeff Law wrote: >> On 11/6/19 1:27 PM, Martin Sebor wrote: >>> On 11/6/19 11:55 AM, Jeff Law wrote: On 11/6/19 11:00 AM, Martin Sebor wrote: > The -Wstringop-overflow warnings for single-byte and multi-byte > stores mention 

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-11 Thread Martin Sebor
On 11/11/19 4:30 AM, Bernhard Reutner-Fischer wrote: On 8 November 2019 17:57:51 CET, Martin Sebor wrote: On 11/6/19 2:06 PM, Martin Sebor wrote: On 11/6/19 1:39 PM, Jeff Law wrote: On 11/6/19 1:27 PM, Martin Sebor wrote: On 11/6/19 11:55 AM, Jeff Law wrote: On 11/6/19 11:00 AM, Martin Sebo

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-11 Thread Bernhard Reutner-Fischer
On 8 November 2019 17:57:51 CET, Martin Sebor wrote: >On 11/6/19 2:06 PM, Martin Sebor wrote: >> On 11/6/19 1:39 PM, Jeff Law wrote: >>> On 11/6/19 1:27 PM, Martin Sebor wrote: On 11/6/19 11:55 AM, Jeff Law wrote: > On 11/6/19 11:00 AM, Martin Sebor wrote: >> The -Wstringop-overflow w

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-08 Thread Martin Sebor
On 11/6/19 2:06 PM, Martin Sebor wrote: On 11/6/19 1:39 PM, Jeff Law wrote: On 11/6/19 1:27 PM, Martin Sebor wrote: On 11/6/19 11:55 AM, Jeff Law wrote: On 11/6/19 11:00 AM, Martin Sebor wrote: The -Wstringop-overflow warnings for single-byte and multi-byte stores mention the amount of data b

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-06 Thread Martin Sebor
On 11/6/19 2:06 PM, Martin Sebor wrote: On 11/6/19 1:39 PM, Jeff Law wrote: On 11/6/19 1:27 PM, Martin Sebor wrote: On 11/6/19 11:55 AM, Jeff Law wrote: On 11/6/19 11:00 AM, Martin Sebor wrote: The -Wstringop-overflow warnings for single-byte and multi-byte stores mention the amount of data b

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-06 Thread Martin Sebor
On 11/6/19 1:39 PM, Jeff Law wrote: On 11/6/19 1:27 PM, Martin Sebor wrote: On 11/6/19 11:55 AM, Jeff Law wrote: On 11/6/19 11:00 AM, Martin Sebor wrote: The -Wstringop-overflow warnings for single-byte and multi-byte stores mention the amount of data being stored and the amount of space remai

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-06 Thread Jeff Law
On 11/6/19 1:27 PM, Martin Sebor wrote: > On 11/6/19 11:55 AM, Jeff Law wrote: >> On 11/6/19 11:00 AM, Martin Sebor wrote: >>> The -Wstringop-overflow warnings for single-byte and multi-byte >>> stores mention the amount of data being stored and the amount of >>> space remaining in the destination,

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-06 Thread Martin Sebor
On 11/6/19 11:55 AM, Jeff Law wrote: On 11/6/19 11:00 AM, Martin Sebor wrote: The -Wstringop-overflow warnings for single-byte and multi-byte stores mention the amount of data being stored and the amount of space remaining in the destination, such as: warning: writing 4 bytes into a region of s

Re: [PATCH] include size and offset in -Wstringop-overflow

2019-11-06 Thread Jeff Law
On 11/6/19 11:00 AM, Martin Sebor wrote: > The -Wstringop-overflow warnings for single-byte and multi-byte > stores mention the amount of data being stored and the amount of > space remaining in the destination, such as: > > warning: writing 4 bytes into a region of size 0 [-Wstringop-overflow=] >

[PATCH] include size and offset in -Wstringop-overflow

2019-11-06 Thread Martin Sebor
The -Wstringop-overflow warnings for single-byte and multi-byte stores mention the amount of data being stored and the amount of space remaining in the destination, such as: warning: writing 4 bytes into a region of size 0 [-Wstringop-overflow=] 123 | *p = 0; | ~~~^~~ note: destinatio