Re: [PATCH] inline: do not inline when no_profile_instrument_function is different

2021-09-06 Thread Jeff Law via Gcc-patches
On 8/18/2021 2:38 AM, Martin Liška wrote: On 6/23/21 3:15 PM, Martin Liška wrote: On 6/23/21 2:38 PM, Jan Hubicka wrote: Is there reason to prevent the inlining once instrumentation is done? No ;) I think you can just block it for early inliner. Sure. Do you have a handy predicate func

Re: [PATCH] inline: do not inline when no_profile_instrument_function is different

2021-08-18 Thread Martin Liška
On 6/23/21 3:15 PM, Martin Liška wrote: On 6/23/21 2:38 PM, Jan Hubicka wrote: Is there reason to prevent the inlining once instrumentation is done? No ;) I think you can just block it for early inliner. Sure. Do you have a handy predicate function that tells if einliner is done? Thanks,

Re: [PATCH] inline: do not inline when no_profile_instrument_function is different

2021-06-25 Thread Nick Desaulniers via Gcc-patches
On Wed, Jun 23, 2021 at 6:15 AM Martin Liška wrote: > > On 6/23/21 2:38 PM, Jan Hubicka wrote: > > Is there reason to prevent the inlining once instrumentation is done? > > No ;) Here's another case that coincidentally came up yesterday. How should these attributes behave in the case of __attribu

Re: [PATCH] inline: do not inline when no_profile_instrument_function is different

2021-06-23 Thread Martin Liška
On 6/23/21 2:38 PM, Jan Hubicka wrote: Is there reason to prevent the inlining once instrumentation is done? No ;) I think you can just block it for early inliner. Sure. Do you have a handy predicate function that tells if einliner is done? Thanks, Martin

Re: [PATCH] inline: do not inline when no_profile_instrument_function is different

2021-06-23 Thread Jan Hubicka
> Hello. > > Similarly to e.g. sanitizer attributes, we sould prevent inlining when one > function > is marked as not instrumented. We should do that with -fprofile-generate only. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > M

[PATCH] inline: do not inline when no_profile_instrument_function is different

2021-06-23 Thread Martin Liška
Hello. Similarly to e.g. sanitizer attributes, we sould prevent inlining when one function is marked as not instrumented. We should do that with -fprofile-generate only. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin Adds test-case