Re: [PATCH] issue consistent warning for past-the-end array stores (PR 91457)

2019-08-28 Thread Jeff Law
On 8/28/19 9:44 AM, Martin Sebor wrote: > With the PR 91490 subset committed, attached is what's left > of the original fix.  It seems simple enough that I decided it's > not worth chopping up any further.  The meat of the change is in > builtins.c.  Everything else just adjusts warnings either by

Re: [PATCH] issue consistent warning for past-the-end array stores (PR 91457)

2019-08-28 Thread Martin Sebor
With the PR 91490 subset committed, attached is what's left of the original fix. It seems simple enough that I decided it's not worth chopping up any further. The meat of the change is in builtins.c. Everything else just adjusts warnings either by making use of it (tree-ssa-strlen.c) or by sett

Re: [PATCH] issue consistent warning for past-the-end array stores (PR 91457)

2019-08-22 Thread Jason Merrill
On Thu, Aug 22, 2019 at 3:43 AM Richard Biener wrote: > On Wed, Aug 21, 2019 at 10:10 PM Martin Sebor wrote: > > On 8/20/19 1:26 AM, Richard Biener wrote: > > > On Tue, Aug 20, 2019 at 4:32 AM Martin Sebor wrote: > > >> On 8/19/19 8:10 AM, Richard Biener wrote: > > >>> On Sat, Aug 17, 2019 at 12

Re: [PATCH] issue consistent warning for past-the-end array stores (PR 91457)

2019-08-22 Thread Jeff Law
On 8/20/19 1:26 AM, Richard Biener wrote: > On Tue, Aug 20, 2019 at 4:32 AM Martin Sebor wrote: >> >> On 8/19/19 8:10 AM, Richard Biener wrote: >>> On Sat, Aug 17, 2019 at 12:43 AM Martin Sebor wrote: With the recent enhancement to the strlen handling of multibyte stores the g++.dg

Re: [PATCH] issue consistent warning for past-the-end array stores (PR 91457)

2019-08-22 Thread Richard Biener
On Wed, Aug 21, 2019 at 10:10 PM Martin Sebor wrote: > > On 8/20/19 1:26 AM, Richard Biener wrote: > > On Tue, Aug 20, 2019 at 4:32 AM Martin Sebor wrote: > >> > >> On 8/19/19 8:10 AM, Richard Biener wrote: > >>> On Sat, Aug 17, 2019 at 12:43 AM Martin Sebor wrote: > > With the recent

Re: [PATCH] issue consistent warning for past-the-end array stores (PR 91457)

2019-08-21 Thread Martin Sebor
On 8/20/19 1:26 AM, Richard Biener wrote: On Tue, Aug 20, 2019 at 4:32 AM Martin Sebor wrote: On 8/19/19 8:10 AM, Richard Biener wrote: On Sat, Aug 17, 2019 at 12:43 AM Martin Sebor wrote: With the recent enhancement to the strlen handling of multibyte stores the g++.dg/warn/Warray-bounds-

Re: [PATCH] issue consistent warning for past-the-end array stores (PR 91457)

2019-08-20 Thread Richard Biener
On Tue, Aug 20, 2019 at 4:32 AM Martin Sebor wrote: > > On 8/19/19 8:10 AM, Richard Biener wrote: > > On Sat, Aug 17, 2019 at 12:43 AM Martin Sebor wrote: > >> > >> With the recent enhancement to the strlen handling of multibyte > >> stores the g++.dg/warn/Warray-bounds-4.C for zero-length arrays

Re: [PATCH] issue consistent warning for past-the-end array stores (PR 91457)

2019-08-19 Thread Martin Sebor
On 8/19/19 8:10 AM, Richard Biener wrote: On Sat, Aug 17, 2019 at 12:43 AM Martin Sebor wrote: With the recent enhancement to the strlen handling of multibyte stores the g++.dg/warn/Warray-bounds-4.C for zero-length arrays started failing on hppa (and probably elsewhere as well). This is part

Re: [PATCH] issue consistent warning for past-the-end array stores (PR 91457)

2019-08-19 Thread Richard Biener
On Sat, Aug 17, 2019 at 12:43 AM Martin Sebor wrote: > > With the recent enhancement to the strlen handling of multibyte > stores the g++.dg/warn/Warray-bounds-4.C for zero-length arrays > started failing on hppa (and probably elsewhere as well). This > is partly the result of the added detection

[PATCH] issue consistent warning for past-the-end array stores (PR 91457)

2019-08-16 Thread Martin Sebor
With the recent enhancement to the strlen handling of multibyte stores the g++.dg/warn/Warray-bounds-4.C for zero-length arrays started failing on hppa (and probably elsewhere as well). This is partly the result of the added detection of past-the-end writes into the strlen pass which detects more