Re: [PATCH] libgccjit: Add support for register variables [PR104072]

2022-04-12 Thread David Malcolm via Gcc-patches
On Wed, 2022-02-09 at 20:33 -0500, Antoni Boucher wrote: > Here's the updated patch. Thanks. I updated the patch somewhat: * fixed up some hunks that didn't quite apply * tweaked the comment in all-non-failing-tests.h * fixed continuation lines in .rst ". function::" clause * test-error-r

Re: [PATCH] libgccjit: Add support for register variables [PR104072]

2022-02-09 Thread Antoni Boucher via Gcc-patches
> > > > [...snip...] > > > > > > > +/* { dg-final { jit-verify-output-file-was-created "" } } */ > > > > > +/* { dg-final { jit-verify-assembler-output > > > > > "movl  \\\$1, > > > > > %r12d" } }

Re: [PATCH] libgccjit: Add support for register variables [PR104072]

2022-01-25 Thread Antoni Boucher via Gcc-patches
See answers below. Le lundi 24 janvier 2022 à 18:20 -0500, David Malcolm a écrit : > On Sat, 2022-01-22 at 19:29 -0500, Antoni Boucher wrote: > > Hi. > > > > Le mardi 18 janvier 2022 à 18:49 -0500, David Malcolm a écrit : > > > On Mon, 2022-01-17 at 19:46 -0500, Antoni Boucher via Gcc-patches > >

Re: [PATCH] libgccjit: Add support for register variables [PR104072]

2022-01-24 Thread Antoni Boucher via Gcc-patches
erify-assembler-output "movl  \\\$2, > > > > %r13d" } } */ > > > > > > How target-specific is this test? > > > > It will only work on x86-64. Should I feature-gate the test > > somehow? > > > Yes; I think you can do this b

Re: [PATCH] libgccjit: Add support for register variables [PR104072]

2022-01-24 Thread David Malcolm via Gcc-patches
On Sat, 2022-01-22 at 19:29 -0500, Antoni Boucher wrote: > Hi. > > Le mardi 18 janvier 2022 à 18:49 -0500, David Malcolm a écrit : > > On Mon, 2022-01-17 at 19:46 -0500, Antoni Boucher via Gcc-patches > > wrote: > > > I missed the comment about the new define, so here's the updated > > > patch. >

Re: [PATCH] libgccjit: Add support for register variables [PR104072]

2022-01-22 Thread Antoni Boucher via Gcc-patches
Hi. Le mardi 18 janvier 2022 à 18:49 -0500, David Malcolm a écrit : > On Mon, 2022-01-17 at 19:46 -0500, Antoni Boucher via Gcc-patches > wrote: > > I missed the comment about the new define, so here's the updated > > patch. > > Thanks for the patch. > > > > Le lundi 17 janvier 2022 à 19:24 -050

Re: [PATCH] libgccjit: Add support for register variables [PR104072]

2022-01-18 Thread David Malcolm via Gcc-patches
On Mon, 2022-01-17 at 19:46 -0500, Antoni Boucher via Gcc-patches wrote: > I missed the comment about the new define, so here's the updated > patch. Thanks for the patch. > > Le lundi 17 janvier 2022 à 19:24 -0500, Antoni Boucher via Jit a > écrit : > > Hi. > > This patch add supports for registe

Re: [PATCH] libgccjit: Add support for register variables [PR104072]

2022-01-18 Thread Antoni Boucher via Gcc-patches
Also, I put the extern in gcc/system.h, but I'm not sure it's the right place. Where should I put it? Le lundi 17 janvier 2022 à 19:46 -0500, Antoni Boucher via Jit a écrit : > I missed the comment about the new define, so here's the updated > patch. > > Le lundi 17 janvier 2022 à 19:24 -0500, An

Re: [PATCH] libgccjit: Add support for register variables [PR104072]

2022-01-17 Thread Antoni Boucher via Gcc-patches
nfo.c, I > wonder if I should run the whole testsuite. > > Thanks for the review. From 2d372a741e9ef29eb377f9edfc6c539d1b2722e5 Mon Sep 17 00:00:00 2001 From: Antoni Boucher Date: Sun, 29 Aug 2021 10:54:55 -0400 Subject: [PATCH] libgccjit: Add support for register variables [PR104072]

[PATCH] libgccjit: Add support for register variables [PR104072]

2022-01-17 Thread Antoni Boucher via Gcc-patches
Date: Sun, 29 Aug 2021 10:54:55 -0400 Subject: [PATCH] libgccjit: Add support for register variables [PR104072] 2022-01-17 Antoni Boucher gcc/jit/ PR target/104072 * docs/topics/compatibility.rst (LIBGCCJIT_ABI_21): New ABI tag. * docs/topics/expressions.rst: Add documentation for the