Ok.
Here's the patch with the updated subject and with format fixed.
Le vendredi 18 juin 2021 à 16:54 -0400, David Malcolm a écrit :
> On Fri, 2021-06-18 at 16:42 -0400, Antoni Boucher wrote:
> > I'm sending the patch once again for review.
> >
> > As it's the first time I'll land a patch, I'm
On Fri, 2021-06-18 at 16:42 -0400, Antoni Boucher wrote:
> I'm sending the patch once again for review.
>
> As it's the first time I'll land a patch, I'm not sure what needs to be
> done when it's approved.
> Do I just commit it to the master branch directly?
Commit (and push), yes, but...
I'm sending the patch once again for review.
As it's the first time I'll land a patch, I'm not sure what needs to be
done when it's approved.
Do I just commit it to the master branch directly?
Thanks!
Le vendredi 11 juin 2021 à 13:49 -0400, David Malcolm a écrit :
> On Thu, 2021-05-27 at 21:22
On Thu, 2021-05-27 at 21:22 -0400, Antoni Boucher wrote:
> Here's the patch with the condition removed.
> I believe everything is now fixed.
> Thanks!
Thanks; this looks good to me. Is this the latest version of the
patch; would you like me to apply it?
Dave
>
> Le jeudi 27 mai 2021 à 18:21
Here's the patch with the condition removed.
I believe everything is now fixed.
Thanks!
Le jeudi 27 mai 2021 à 18:21 -0400, David Malcolm a écrit :
> On Tue, 2021-05-25 at 20:16 -0400, Antoni Boucher wrote:
> > I updated the patch according to the comments by Tom Tromey.
> >
> > There's one
On Tue, 2021-05-25 at 20:16 -0400, Antoni Boucher wrote:
> I updated the patch according to the comments by Tom Tromey.
>
> There's one question left about your question regarding
> C_MAYBE_CONST_EXPR, David:
>
> I am not sure if we can get a C_MAYBE_CONST_EXPR from libgccjit, and
> it
> indeed
I updated the patch according to the comments by Tom Tromey.
There's one question left about your question regarding
C_MAYBE_CONST_EXPR, David:
I am not sure if we can get a C_MAYBE_CONST_EXPR from libgccjit, and it
indeed seems like it's only created in c-family.
However, we do use it in
On Thu, 2021-05-13 at 19:31 -0400, Antoni Boucher wrote:
> Thanks for your answer.
>
> See my answers below:
>
> Le jeudi 13 mai 2021 à 18:13 -0400, David Malcolm a écrit :
> > On Sat, 2021-02-20 at 17:17 -0500, Antoni Boucher via Gcc-patches
> > wrote:
> > > Hi.
> > > Thanks for your feedback!
Thanks for your answer.
See my answers below:
Le jeudi 13 mai 2021 à 18:13 -0400, David Malcolm a écrit :
> On Sat, 2021-02-20 at 17:17 -0500, Antoni Boucher via Gcc-patches
> wrote:
> > Hi.
> > Thanks for your feedback!
> >
>
> Sorry about the delay in responding.
>
> In the past I was
On Sat, 2021-02-20 at 17:17 -0500, Antoni Boucher via Gcc-patches
wrote:
> Hi.
> Thanks for your feedback!
>
Sorry about the delay in responding.
In the past I was hesitant about adding more cast support to libgccjit
since I felt that the user could always just create a union to do the
cast.
@David: PING
On 2/20/21 11:17 PM, Antoni Boucher via Gcc-patches wrote:
Hi.
Thanks for your feedback!
See answers below:
On Sat, Feb 20, 2021 at 11:20:35AM -0700, Tom Tromey wrote:
"Antoni" == Antoni Boucher via Gcc-patches writes:
Antoni> gcc/jit/
Antoni> PR target/95498
Antoni>
Hi.
Thanks for your feedback!
See answers below:
On Sat, Feb 20, 2021 at 11:20:35AM -0700, Tom Tromey wrote:
"Antoni" == Antoni Boucher via Gcc-patches writes:
Antoni> gcc/jit/
Antoni> PR target/95498
Antoni> * jit-playback.c: Add support to handle truncation and extension
Antoni>
> "Antoni" == Antoni Boucher via Gcc-patches
> writes:
Antoni> gcc/jit/
Antoni> PR target/95498
Antoni> * jit-playback.c: Add support to handle truncation and extension
Antoni> in the convert function.
Antoni> + switch (dst_code)
Antoni> +{
Antoni> +
Hi.
I'd like to know what's the status of the review for this patch.
(Same for my other patch 96889: add some reflection functions in the jit
C api)
Thanks.
On Tue, Jul 21, 2020 at 11:29:57PM +0200, Andrea Corallo wrote:
Hi Antoni,
a couple of nits and some thoughts.
Antoni Boucher via
Hi.
Sorry for the long delay.
I attached the updated patch.
For your question, the current code already works with boolean and reals
and casts between integers and pointers is currently not supported.
The tests now pass: I'm assuming I had to clean the build folder or
something to make that
Hi Antoni,
a couple of nits and some thoughts.
Antoni Boucher via Gcc-patches writes:
> 2020-07-12 Antoni Boucher
>
> gcc/jit/
> PR target/95498
> * jit-playback.c: Add support to handle truncation and extension
^^^
here we usually
On Sun, 2020-07-12 at 20:30 -0400, Antoni Boucher via Jit wrote:
> Hello.
>
> As mentioned in bug 95498, some conversions do not work. After
> investigation, it turns out that it's caused by multiple casts on an
> expression where it should do a truncation/extension.
Thanks for investigating
Hello.
As mentioned in bug 95498, some conversions do not work. After
investigation, it turns out that it's caused by multiple casts on an
expression where it should do a truncation/extension.
I added a testcase, but for some reasons, the tests only pass when ran
via
18 matches
Mail list logo
