Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-08-19 Thread Yuao Ma
anced. Thanks, YuaoFrom a3d6e00f3c3a2268ea1af1ef57c381f3ed43dcae Mon Sep 17 00:00:00 2001 From: Yuao Ma Date: Wed, 20 Aug 2025 01:03:47 +0800 Subject: [PATCH] libgfortran: add fallback for trigonometric pi-based functions This patch introduces a fallback implementation for pi-based trigonometric func

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-08-05 Thread Yuao Ma
On 8/6/2025 5:05 AM, Joseph Myers wrote: On Tue, 5 Aug 2025, Yuao Ma wrote: On 8/5/2025 4:05 AM, Joseph Myers wrote: On Sun, 3 Aug 2025, Yuao Ma wrote: By the way, could you please take another look at the libquadmath update? https://inbox.sourceware.org/fortran/kl1pr0601mb4291e1457dc09f

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-08-05 Thread Joseph Myers
On Tue, 5 Aug 2025, Yuao Ma wrote: > On 8/5/2025 4:05 AM, Joseph Myers wrote: > > On Sun, 3 Aug 2025, Yuao Ma wrote: > > > > > By the way, could you please take another look at the libquadmath update? > > > > > > https://inbox.sourceware.org/fortran/kl1pr0601mb4291e1457dc09fe3aa6652c884...@kl1pr

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-08-04 Thread Yuao Ma
On 8/5/2025 4:05 AM, Joseph Myers wrote: On Sun, 3 Aug 2025, Yuao Ma wrote: By the way, could you please take another look at the libquadmath update? https://inbox.sourceware.org/fortran/kl1pr0601mb4291e1457dc09fe3aa6652c884...@kl1pr0601mb4291.apcprd06.prod.outlook.com/ Using the script

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-08-04 Thread Joseph Myers
On Sun, 3 Aug 2025, Yuao Ma wrote: > By the way, could you please take another look at the libquadmath update? > > https://inbox.sourceware.org/fortran/kl1pr0601mb4291e1457dc09fe3aa6652c884...@kl1pr0601mb4291.apcprd06.prod.outlook.com/ > > This update uses a script to transform glibc's implement

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-08-03 Thread Yuao Ma
On 7/31/2025 1:45 AM, Joseph Myers wrote: On Sun, 6 Jul 2025, Yuao Ma wrote: +#ifndef HAVE_COSPI +#define HAVE_COSPI 1 +double cospi (double); + +double +cospi (double x) +{ + return cos (x * pihi_d + x * pilo_d); For reasonable results for large x you should first reduce mod 2 to the ran

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-07-30 Thread Joseph Myers
On Sun, 6 Jul 2025, Yuao Ma wrote: > +#ifndef HAVE_COSPI > +#define HAVE_COSPI 1 > +double cospi (double); > + > +double > +cospi (double x) > +{ > + return cos (x * pihi_d + x * pilo_d); For reasonable results for large x you should first reduce mod 2 to the range [-1, 1] (or reduce mod 1 and

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-07-08 Thread Yuao Ma
On 7/8/2025 2:03 AM, Steve Kargl wrote: On Sun, Jul 06, 2025 at 09:09:53PM +0800, Yuao Ma wrote: Hi Tobias, On 7/6/2025 6:34 PM, Tobias Burnus wrote: As that commit is from 2020 and 2.69 in from 2012, it seems as if your autoconf is too new. Can you re-check that the right version is at the

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-07-07 Thread Steve Kargl
On Sun, Jul 06, 2025 at 09:09:53PM +0800, Yuao Ma wrote: > Hi Tobias, > > On 7/6/2025 6:34 PM, Tobias Burnus wrote: > > As that commit is from 2020 and 2.69 in from 2012, it seems as if your > > autoconf is too new. Can you re-check that the right version is at the > > beginning of the PATH? > >

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-07-06 Thread Yuao Ma
rsion to create a new patch. Hope this looks good to you. YuaoFrom 2d62a2f707e43f37b4d886b7ed3aa40f2ab62437 Mon Sep 17 00:00:00 2001 From: Yuao Ma Date: Sun, 6 Jul 2025 20:55:08 +0800 Subject: [PATCH] libgfortran: add fallback for trigonometric pi-based functions This patch introduces a fal

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-07-06 Thread Tobias Burnus
On Sunday, July 6, 2025, Yuao Ma wrote: >>> Since I don't have root/sudo permissions on my devbox, I manually downloaded >>> and compiled the autoconf 2.69 tarball. This means there might be some minor >>> discrepancies compared to the version shipped with OS distributions. In principle, having a

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-07-05 Thread Yuao Ma
On 7/6/2025 12:49 PM, Steve Kargl wrote: On Sun, Jul 06, 2025 at 08:43:06AM +0800, Yuao Ma wrote: Hi Steve, On 7/6/2025 12:25 AM, Steve Kargl wrote: On Sat, Jul 05, 2025 at 05:20:02PM +0800, Yuao Ma wrote: diff --git a/libgfortran/configure b/libgfortran/configure index 9898a94a372..971f1e

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-07-05 Thread Steve Kargl
On Sun, Jul 06, 2025 at 08:43:06AM +0800, Yuao Ma wrote: > Hi Steve, > > On 7/6/2025 12:25 AM, Steve Kargl wrote: > > On Sat, Jul 05, 2025 at 05:20:02PM +0800, Yuao Ma wrote: > > > diff --git a/libgfortran/configure b/libgfortran/configure > > > index 9898a94a372..971f1e9df5e 100755 > > > --- a/li

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-07-05 Thread Yuao Ma
Hi Steve, On 7/6/2025 12:25 AM, Steve Kargl wrote: On Sat, Jul 05, 2025 at 05:20:02PM +0800, Yuao Ma wrote: diff --git a/libgfortran/configure b/libgfortran/configure index 9898a94a372..971f1e9df5e 100755 --- a/libgfortran/configure +++ b/libgfortran/configure @@ -16413,7 +16413,7 @@ else

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-07-05 Thread Steve Kargl
On Sat, Jul 05, 2025 at 05:20:02PM +0800, Yuao Ma wrote: > > diff --git a/libgfortran/configure b/libgfortran/configure > index 9898a94a372..971f1e9df5e 100755 > --- a/libgfortran/configure > +++ b/libgfortran/configure > @@ -16413,7 +16413,7 @@ else > We can't simply define LARGE_OFF_T to b

[PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-07-05 Thread Yuao Ma
: add fallback for trigonometric pi-based functions This patch introduces a fallback implementation for pi-based trigonometric functions, ensuring broader compatibility and robustness. The new implementation supports float, double, and long double data types. Accordingly, the test cases for r4 and r8