On Tue, Aug 22, 2023 at 10:25:51AM +0200, FX Coudert wrote:
> > Revised patch. I does the job on darwin, can you check that it still tests
> > the functions on Linux?
> > And if so, OK to commit?
>
> With the correct file, sorry.
Seems to work for me, I see
... -DNONSTDFUNC=1 ...
on the test's
> Revised patch. I does the job on darwin, can you check that it still tests
> the functions on Linux?
> And if so, OK to commit?
With the correct file, sorry.
0001-libgomp-testsuite-Do-not-call-nonstandard-functions.patch
Description: Binary data
On Tue, Aug 22, 2023 at 10:16:37AM +0200, FX Coudert wrote:
> Revised patch. I does the job on darwin, can you check that it still tests
> the functions on Linux?
Seems the attached patch doesn't match what was discussed in this thread.
And for that DWARF patch, I'd like to see what different
Revised patch. I does the job on darwin, can you check that it still tests the
functions on Linux?
And if so, OK to commit?
FX
0001-Testsuite-DWARF2-adjust-regexp-to-match-darwin-outpu.patch
Description: Binary data
On Mon, Aug 21, 2023 at 10:00:30PM +0200, FX Coudert wrote:
> >> I understand, I wanted to not just report the issue but propose an option.
> >> It seems a bit heavy to design an effective target just for one test,
> >> though, no?
> >
> > It has the advantage of getting it right on all current
>> I understand, I wanted to not just report the issue but propose an option.
>> It seems a bit heavy to design an effective target just for one test,
>> though, no?
>
> It has the advantage of getting it right on all current and future targets.
Something like this? (not tested yet)
diff
On Mon, Aug 21, 2023 at 09:50:37PM +0200, FX Coudert wrote:
> > I don't like the #if !defined(__APPLE__) conditionals everywhere in the
> > test, I think much cleaner would be to add an effective target to test
> > for those functions
>
> I understand, I wanted to not just report the issue but
> I don't like the #if !defined(__APPLE__) conditionals everywhere in the
> test, I think much cleaner would be to add an effective target to test
> for those functions
I understand, I wanted to not just report the issue but propose an option. It
seems a bit heavy to design an effective target
On Mon, Aug 21, 2023 at 09:12:09PM +0200, Tobias Burnus wrote:
> OK. — I'd prefer if you also changed + tested a fix for my (a) + (b)
> remarks, but as those are unrelated, I understand if you don't and just
> commit your Darwin patch.
I don't like the #if !defined(__APPLE__) conditionals
p 17 00:00:00 2001
From: Francois-Xavier Coudert
Date: Sun, 20 Aug 2023 21:32:18 +0200
Subject: [PATCH] libgomp, testsuite: Do not call nonstandard functions on
darwin
The following functions are not standard, and not always available on
darwin. They should not be called there: gamma, gammaf, scal
Hi,
testsuite/libgomp.c/simd-math-1.c calls nonstandard functions that are not
available on darwin (and possibly other systems?). Because I did not want to
disable their testing completely, I suggest we simply use preprocessor macros
to avoid them on darwin.
This fixes the test failure on
11 matches
Mail list logo
