Hello,
On Fri, Jun 26, 2020 at 1:08 PM Jakub Jelinek wrote:
> On Fri, Jun 26, 2020 at 12:57:59PM -0400, y2s1982 . wrote:
> > > > * env.c(ompd_dll_locations_valid): Define with no compiler
> > > optimization.
> > >
> > > Again, missing space.
> > >
> > > The contrib/mklog.py, which I use to
On Fri, Jun 26, 2020 at 12:57:59PM -0400, y2s1982 . wrote:
> > > * env.c(ompd_dll_locations_valid): Define with no compiler
> > optimization.
> >
> > Again, missing space.
> >
> > The contrib/mklog.py, which I use to generate these messages, seems to
> generate the statement without a space a
Hello,
On Fri, Jun 26, 2020 at 5:03 AM Jakub Jelinek wrote:
> Thanks, just nits, no need to repost, just commit it after you make those
> changes.
>
> On Thu, Jun 25, 2020 at 05:58:23PM -0400, y2s1982 via Gcc-patches wrote:
>
> > * Makefile.am(toolexeclib_LTLIBRARIES): Add libgompd.la.
>
>
Thanks, just nits, no need to repost, just commit it after you make those
changes.
On Thu, Jun 25, 2020 at 05:58:23PM -0400, y2s1982 via Gcc-patches wrote:
> * Makefile.am(toolexeclib_LTLIBRARIES): Add libgompd.la.
Missing space between am and (.
> (libgompd_la_LDFLAGS, libgompd_l
From: y2s82 <1997371+y2...@users.noreply.github.com>
This patch adds some unit tests for omp-tools.h header. It also adds some simple
functions variables related to OMPD API versions and dll locations.
It also partially defines the OMPD initialization function.
More OMPD configuration is also adde
On Thu, Jun 25, 2020 at 12:27:32PM -0400, y2s1982 . via Gcc-patches wrote:
> > > --- /dev/null
> > > +++ b/libgomp/libgompd.map
> > > @@ -0,0 +1,49 @@
> > > +OMPD_5.0 {
> > > + global:
> > > + ompd_dll_locations_valid;
> >
> > ompd_dll_locations and ompd_dll_locations_valid both need to be exp
On Thu, Jun 25, 2020 at 12:17:05PM -0400, y2s1982 . wrote:
> Ah, so code in env.c gets executed before OMPD gets started?
Not all, but initialize_env is the library constructor (has constructor
attribute) and is invoked during the library initialization.
>
> Include omp-tools.h and plugin-suffix.
>
>
> > --- /dev/null
> > +++ b/libgomp/libgompd.map
> > @@ -0,0 +1,49 @@
> > +OMPD_5.0 {
> > + global:
> > + ompd_dll_locations_valid;
>
> ompd_dll_locations and ompd_dll_locations_valid both need to be exported,
> but not from libgompd.so.1 but from libgomp.so.1, so they need to go into
> li
Hello Jakub,
Thank you for the feedback. I can't believe I made some careless mistakes.
I am also very interested in learning some new techniques mentioned. I had
some questions about them.
On Thu, Jun 25, 2020 at 4:28 AM Jakub Jelinek wrote:
>
> > --- /dev/null
> > +++ b/libgomp/libgompd.map
>
On Wed, Jun 24, 2020 at 09:22:51PM -0400, y2s1982 wrote:
> +#ifndef LIBGOMPD_H
> +#define LIBGOMPD_H 1
> +
> +#define ompd_str1(x) ompd_str2(x)
> +#define ompd_str2(x) #x
I'd call ompd_str1 (the one that should be actually used)
just ompd_str or ompd_stringify.
> --- /dev/null
> +++ b/libgomp/lib
This patch adds some unit tests for omp-tools.h header. It also adds some simple
functions related to OMPD API versions. It also partially defines the OMPD
initialization function. More OMPD configuration is also added into Makefile.am.
2020-06-24 Tony Sim
libgomp/ChangeLog:
* Makefil
On Wed, Jun 24, 2020 at 06:03:26PM +0200, Tobias Burnus wrote:
> On 6/24/20 5:26 PM, Jakub Jelinek via Gcc-patches wrote:
>
> > Just build the whole gcc tree.
> > If you are at the toplevel of gcc tree (i.e. directory that contains libgomp
> > subdirectory), do
> > mkdir obj
> > cd obj
> > ../conf
On 6/24/20 5:26 PM, Jakub Jelinek via Gcc-patches wrote:
Just build the whole gcc tree.
If you are at the toplevel of gcc tree (i.e. directory that contains libgomp
subdirectory), do
mkdir obj
cd obj
../configure --disable-bootstrap --enable-languages=c,c++,fortran
make -j16 # or how many cores
On Wed, Jun 24, 2020 at 11:11:47AM -0400, y2s1982 . wrote:
> > And introduce libgompd.map version script which will have the exported
> > symbols in for now OMPD_5.0 symbol version.
> > So
> > OMPD_5.0 {
> > global:
> > ...;
> >
> > local:
> > *;
> > };
> >
>
> Oh I wasn't sure
Hello,
Thank you for the tips. I have some follow up questions. :)
On Wed, Jun 24, 2020 at 5:25 AM Jakub Jelinek wrote:
> > libgomp/ChangeLog:
> >
> > * Makefile.am (toolexeclib_LTLIBRARIES and related): Add
> libgompd.la.
>
> Please spell out all the changes. I.e.
> * Makefile.a
On Tue, Jun 23, 2020 at 07:25:22PM -0400, y2s1982 via Gcc-patches wrote:
> --- /dev/null
> +++ b/libgomp/libgompd.c
> @@ -0,0 +1,46 @@
Oh, and one more thing, this file should start with the standard comment
with license etc., like you've added it to omp-tools.h.
> --- /dev/null
> +++ b/libgomp/l
On Tue, Jun 23, 2020 at 07:25:22PM -0400, y2s1982 via Gcc-patches wrote:
> This patch adds some unit tests for omp-tools.h header. It also adds some
> simple
> functions related to OMPD API versions. It also partially defines the OMPD
> initialization function.
>
> 2020-06-23 Tony Sim
>
> lib
This patch adds some unit tests for omp-tools.h header. It also adds some simple
functions related to OMPD API versions. It also partially defines the OMPD
initialization function.
2020-06-23 Tony Sim
libgomp/ChangeLog:
* Makefile.am (toolexeclib_LTLIBRARIES and related): Add libgompd
18 matches
Mail list logo
