[PATCH] libiberty: Fix -Wimplicit-fallthrough warnings.

2016-11-02 Thread Mark Wielaard
Adjust some comments, add some explicit fall through comments or explicit returns where necessary to not get implicit-fallthrough warnings. All fall throughs were deliberate. In one case I added an explicit return false for clarity instead of falling through a default case (that also would return

Re: [PATCH] libiberty: Fix -Wimplicit-fallthrough warnings.

2016-11-18 Thread Allan Sandfeld Jensen
On Wednesday 02 November 2016, Mark Wielaard wrote: > -case 11: c+=((hashval_t)k[10]<<24); > -case 10: c+=((hashval_t)k[9]<<16); > -case 9 : c+=((hashval_t)k[8]<<8); > +case 11: c+=((hashval_t)k[10]<<24); /* fall through */ > +case 10: c+=((hashval_t)k[9]<<16); /* f

Re: [PATCH] libiberty: Fix -Wimplicit-fallthrough warnings.

2016-11-02 Thread Jakub Jelinek
On Wed, Nov 02, 2016 at 02:19:33PM +0100, Mark Wielaard wrote: > Adjust some comments, add some explicit fall through comments or explicit > returns where necessary to not get implicit-fallthrough warnings. > > All fall throughs were deliberate. In one case I added an explicit return > false for c

Re: [PATCH] libiberty: Fix -Wimplicit-fallthrough warnings.

2016-11-04 Thread Mark Wielaard
On Wed, 2016-11-02 at 14:24 +0100, Jakub Jelinek wrote: > On Wed, Nov 02, 2016 at 02:19:33PM +0100, Mark Wielaard wrote: > > libiberty/ChangeLog: > > > >* cplus-dem.c (demangle_signature): Move fall through comment. > >(demangle_fund_type): Add fall through comment between 'G' and