[PATCH] libiberty: stop using PTR macro.

2022-05-10 Thread Martin Liška
Hi. As noticed by Alan, we can stop using the non-ANSI C specific macro (PTR). Let's removed its usafe in libiberty. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin include/ChangeLog: * hashtab.h (HTAB_EMPTY_ENTRY): Use void

Re: [PATCH] libiberty: stop using PTR macro.

2022-05-10 Thread Jeff Law via Gcc-patches
On 5/10/2022 2:56 AM, Martin Liška wrote: Hi. As noticed by Alan, we can stop using the non-ANSI C specific macro (PTR). Let's removed its usafe in libiberty. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin include/ChangeLog:

Re: [PATCH] libiberty: stop using PTR macro.

2022-05-10 Thread Eric Gallager via Gcc-patches
On Tue, May 10, 2022 at 5:37 AM Martin Liška wrote: > > Hi. > > As noticed by Alan, we can stop using the non-ANSI C specific macro (PTR). > Let's removed its usafe in libiberty. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Marti

Re: [PATCH] libiberty: stop using PTR macro.

2022-05-10 Thread Martin Liška
On 5/10/22 15:50, Eric Gallager wrote: > Hi, please preserve existing style when possible when making this > replacement; ISTR there are some tools (like for generating > libiberty's documentation) that depend on the return type being on a > separate line... If all of the relevant Makefile targets

Re: [PATCH] libiberty: stop using PTR macro.

2022-05-10 Thread Alan Modra via Gcc-patches
On Tue, May 10, 2022 at 10:56:22AM +0200, Martin Liška wrote: > diff --git a/libiberty/hashtab.c b/libiberty/hashtab.c > @@ -457,15 +457,15 @@ htab_empty (htab_t htab) >else if (htab->free_with_arg_f != NULL) > (*htab->free_with_arg_f) (htab->alloc_arg, htab->entries); >if (

Re: [PATCH] libiberty: stop using PTR macro.

2022-05-10 Thread Martin Liška
On 5/10/22 16:20, Alan Modra wrote: > On Tue, May 10, 2022 at 10:56:22AM +0200, Martin Liška wrote: > >> diff --git a/libiberty/hashtab.c b/libiberty/hashtab.c > >> @@ -457,15 +457,15 @@ htab_empty (htab_t htab) >>else if (htab->free_with_arg_f != NULL) >> (*htab->free_with_arg_f) (h