Re: [PATCH] libstdc++: Add error handler for

2022-12-07 Thread Jonathan Wakely via Gcc-patches
On Wed, 7 Dec 2022 at 17:58, François Dumont wrote: > > Looks perfect to me, thanks. OK thanks, it's pushed to trunk now. > > On 06/12/22 22:44, Jonathan Wakely wrote: > > On Wed, 30 Nov 2022 at 18:00, François Dumont wrote: > >> On 30/11/22 14:07, Jonathan Wakely wrote: > >>> On Wed, 30 Nov 2

Re: [PATCH] libstdc++: Add error handler for

2022-12-07 Thread François Dumont via Gcc-patches
Looks perfect to me, thanks. On 06/12/22 22:44, Jonathan Wakely wrote: On Wed, 30 Nov 2022 at 18:00, François Dumont wrote: On 30/11/22 14:07, Jonathan Wakely wrote: On Wed, 30 Nov 2022 at 11:57, Jonathan Wakely wrote: On Wed, 30 Nov 2022 at 11:54, Jonathan Wakely wrote: On Wed, 30 Nov

Re: [PATCH] libstdc++: Add error handler for

2022-12-06 Thread Jonathan Wakely via Gcc-patches
On Wed, 30 Nov 2022 at 18:00, François Dumont wrote: > > On 30/11/22 14:07, Jonathan Wakely wrote: > > On Wed, 30 Nov 2022 at 11:57, Jonathan Wakely wrote: > >> > >> > >> On Wed, 30 Nov 2022 at 11:54, Jonathan Wakely wrote: > >>> > >>> > >>> On Wed, 30 Nov 2022 at 06:04, François Dumont via Libs

Re: [PATCH] libstdc++: Add error handler for

2022-11-30 Thread Björn Schäpers
One could (for a manual test) always change libbacktrace to call the callback. Or invoke it on a platform where libbacktrace can't figure out the executable path on its own, like currently windows. As for an automated test, I have no idea how to enforce that, without changing the code to be te

Re: [PATCH] libstdc++: Add error handler for

2022-11-30 Thread François Dumont via Gcc-patches
On 30/11/22 14:07, Jonathan Wakely wrote: On Wed, 30 Nov 2022 at 11:57, Jonathan Wakely wrote: On Wed, 30 Nov 2022 at 11:54, Jonathan Wakely wrote: On Wed, 30 Nov 2022 at 06:04, François Dumont via Libstdc++ wrote: Good catch, then we also need this patch. Is it worth printing an err

Re: [PATCH] libstdc++: Add error handler for

2022-11-30 Thread François Dumont via Gcc-patches
On 30/11/22 14:07, Jonathan Wakely wrote: On Wed, 30 Nov 2022 at 11:57, Jonathan Wakely wrote: On Wed, 30 Nov 2022 at 11:54, Jonathan Wakely wrote: On Wed, 30 Nov 2022 at 06:04, François Dumont via Libstdc++ wrote: Good catch, then we also need this patch. Is it worth printing an err

Re: [PATCH] libstdc++: Add error handler for

2022-11-30 Thread Jonathan Wakely via Gcc-patches
On Wed, 30 Nov 2022 at 11:57, Jonathan Wakely wrote: > > > > On Wed, 30 Nov 2022 at 11:54, Jonathan Wakely wrote: >> >> >> >> On Wed, 30 Nov 2022 at 06:04, François Dumont via Libstdc++ >> wrote: >>> >>> Good catch, then we also need this patch. >> >> >> Is it worth printing an error? If we can

Re: [PATCH] libstdc++: Add error handler for

2022-11-30 Thread Jonathan Wakely via Gcc-patches
Resending with the typo in the mailing list address fixed... On Wed, 30 Nov 2022 at 12:31, Jonathan Wakely wrote: > > On Tue, 29 Nov 2022 at 21:41, Björn Schäpers wrote: > > > > From: Björn Schäpers > > > > Not providing an error handler results in a nullpointer dereference when > > an error occ

Fwd: [PATCH] libstdc++: Add error handler for

2022-11-29 Thread Björn Schäpers
Weitergeleitete Nachricht Betreff: [PATCH] libstdc++: Add error handler for Datum: Tue, 29 Nov 2022 22:41:07 +0100 Von: Björn Schäpers An: gcc-patc...@gc.gnu.org, libstd...@gcc.gnu.org From: Björn Schäpers Not providing an error handler results in a nullpointer