Re: [Ping][PATCH] libstdc++: Add missing functions to [PR79700]

2023-11-10 Thread Jonathan Wakely
I've finally convinced myself that this patch is OK, because we provide stub versions of all the functions being declared here. So if a target is missing them, we provide them anyway. That happens to be broken for the avr target, but that defaults to --disable-libstdcxx anyway. I've pushed the

Re: [Ping][PATCH] libstdc++: Add missing functions to [PR79700]

2023-05-17 Thread Jonathan Wakely via Gcc-patches
On Wed, 17 May 2023 at 10:38, Nathaniel Shead wrote: > On Wed, May 17, 2023 at 10:05:59AM +0100, Jonathan Wakely wrote: > > On Wed, 17 May 2023 at 09:37, Nathaniel Shead wrote: > > > > > Now that GCC13.1 is released is it ok to merge? Thanks! > > > > > > > Yes, I've been testing this locally,

Re: [Ping][PATCH] libstdc++: Add missing functions to [PR79700]

2023-05-17 Thread Nathaniel Shead via Gcc-patches
On Wed, May 17, 2023 at 10:05:59AM +0100, Jonathan Wakely wrote: > On Wed, 17 May 2023 at 09:37, Nathaniel Shead wrote: > > > Now that GCC13.1 is released is it ok to merge? Thanks! > > > > Yes, I've been testing this locally, but I think it needs more work (sorry!) > > Looking at it again, I'm

Re: [Ping][PATCH] libstdc++: Add missing functions to [PR79700]

2023-05-17 Thread Jonathan Wakely via Gcc-patches
On Wed, 17 May 2023 at 09:37, Nathaniel Shead wrote: > Now that GCC13.1 is released is it ok to merge? Thanks! > Yes, I've been testing this locally, but I think it needs more work (sorry!) Looking at it again, I'm not sure why I asked for the additional tests because if they fail, it's a

Re: [Ping][PATCH] libstdc++: Add missing functions to [PR79700]

2023-05-17 Thread Nathaniel Shead via Gcc-patches
Now that GCC13.1 is released is it ok to merge? Thanks! On Tue, Apr 18, 2023 at 6:48 PM Jonathan Wakely wrote: > > On Mon, 17 Apr 2023 at 09:11, Nathaniel Shead > wrote: > > > > Hi, just checking whether there were any issues with this patch? > >

Re: [Ping][PATCH] libstdc++: Add missing functions to [PR79700]

2023-04-18 Thread Jonathan Wakely via Gcc-patches
On Mon, 17 Apr 2023 at 09:11, Nathaniel Shead wrote: > > Hi, just checking whether there were any issues with this patch? > https://gcc.gnu.org/pipermail/gcc-patches/2023-February/612386.html > > Otherwise I assume it won't be in GCC13. That's right, it's too large and invasive a change to get

[Ping][PATCH] libstdc++: Add missing functions to [PR79700]

2023-04-17 Thread Nathaniel Shead via Gcc-patches
Hi, just checking whether there were any issues with this patch? https://gcc.gnu.org/pipermail/gcc-patches/2023-February/612386.html Otherwise I assume it won't be in GCC13. Thanks, Nathaniel

Re: [PATCH] libstdc++: Add missing functions to [PR79700]

2023-02-21 Thread Nathaniel Shead via Gcc-patches
On Mon, Feb 20, 2023 at 12:08:38PM +, Jonathan Wakely wrote: > On Mon, 20 Feb 2023 at 11:57, Nathaniel Shead > wrote: > > > > On Mon, Feb 20, 2023 at 10:30 PM Jonathan Wakely wrote: > > > > > > On Mon, 20 Feb 2023 at 11:23, Nathaniel Shead via Libstdc++ > > > wrote: > > > > > > > > The

Re: [PATCH] libstdc++: Add missing functions to [PR79700]

2023-02-20 Thread Jonathan Wakely via Gcc-patches
On Mon, 20 Feb 2023 at 11:57, Nathaniel Shead wrote: > > On Mon, Feb 20, 2023 at 10:30 PM Jonathan Wakely wrote: > > > > On Mon, 20 Feb 2023 at 11:23, Nathaniel Shead via Libstdc++ > > wrote: > > > > > > The comments on PR79700 mentioned that it was somewhat ambiguous whether > > > these

Re: [PATCH] libstdc++: Add missing functions to [PR79700]

2023-02-20 Thread Nathaniel Shead via Gcc-patches
On Mon, Feb 20, 2023 at 10:30 PM Jonathan Wakely wrote: > > On Mon, 20 Feb 2023 at 11:23, Nathaniel Shead via Libstdc++ > wrote: > > > > The comments on PR79700 mentioned that it was somewhat ambiguous whether > > these functions were supposed to exist for C++11 or not. I chose to add > > them

Re: [PATCH] libstdc++: Add missing functions to [PR79700]

2023-02-20 Thread Jonathan Wakely via Gcc-patches
On Mon, 20 Feb 2023 at 11:23, Nathaniel Shead via Libstdc++ wrote: > > The comments on PR79700 mentioned that it was somewhat ambiguous whether > these functions were supposed to exist for C++11 or not. I chose to add > them there, since other resources (such as cppreference) seem to think > that

[PATCH] libstdc++: Add missing functions to [PR79700]

2023-02-20 Thread Nathaniel Shead via Gcc-patches
The comments on PR79700 mentioned that it was somewhat ambiguous whether these functions were supposed to exist for C++11 or not. I chose to add them there, since other resources (such as cppreference) seem to think that C++11 should be the standard these functions were introduced, and I don't