Re: [PATCH] libstdc++: reduce std::variant template instantiation depth

2024-01-15 Thread Jonathan Wakely
On Mon, 15 Jan 2024 at 19:32, Patrick Palka wrote: > > On Sun, Jan 7, 2024 at 3:33 PM Patrick Palka wrote: > > > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk? > > Ping. Huh, I thought I'd already approved this ... sorry. OK for trunk, with the -ftemplate-depth test change too.

Re: [PATCH] libstdc++: reduce std::variant template instantiation depth

2024-01-15 Thread Patrick Palka
On Sun, Jan 7, 2024 at 3:33 PM Patrick Palka wrote: > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk? Ping. > > -- >8 -- > > The recursively defined constraints on _Variadic_union's user-defined > destructor (necessary for maintaining trivial destructibility of the > variant iff

Re: [PATCH] libstdc++: reduce std::variant template instantiation depth

2024-01-07 Thread Patrick Palka
On Sun, 7 Jan 2024, Patrick Palka wrote: > Tested on x86_64-pc-linux-gnu, does this look OK for trunk? > > -- >8 -- > > The recursively defined constraints on _Variadic_union's user-defined > destructor (necessary for maintaining trivial destructibility of the > variant iff all of its

[PATCH] libstdc++: reduce std::variant template instantiation depth

2024-01-07 Thread Patrick Palka
Tested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- The recursively defined constraints on _Variadic_union's user-defined destructor (necessary for maintaining trivial destructibility of the variant iff all of its alternatives are) effectively require a template instantiation