Re: [PATCH] libstdc++: std::variant doesn't like types with a defaulted virtual destructor [PR95915]

2020-06-28 Thread Jonathan Wakely via Gcc-patches
On 27/06/20 18:20 +0300, Ville Voutilainen via Libstdc++ wrote: On Sat, 27 Jun 2020 at 17:53, Ville Voutilainen wrote: On Fri, 26 Jun 2020 at 21:20, Jonathan Wakely wrote: > For these three tests I think this would be slightly better: > > // { dg-additional-options "-Wno-deprecated" { target

Re: [PATCH] libstdc++: std::variant doesn't like types with a defaulted virtual destructor [PR95915]

2020-06-27 Thread Ville Voutilainen via Gcc-patches
On Sat, 27 Jun 2020 at 17:53, Ville Voutilainen wrote: > > On Fri, 26 Jun 2020 at 21:20, Jonathan Wakely wrote: > > For these three tests I think this would be slightly better: > > > > // { dg-additional-options "-Wno-deprecated" { target c++17 } } > > > > That way we only ignore the warning

Re: [PATCH] libstdc++: std::variant doesn't like types with a defaulted virtual destructor [PR95915]

2020-06-27 Thread Ville Voutilainen via Gcc-patches
On Fri, 26 Jun 2020 at 21:20, Jonathan Wakely wrote: > For these three tests I think this would be slightly better: > > // { dg-additional-options "-Wno-deprecated" { target c++17 } } > > That way we only ignore the warning when actually needed. Sure thing. The test run revealed some additional

Re: [PATCH] libstdc++: std::variant doesn't like types with a defaulted virtual destructor [PR95915]

2020-06-26 Thread Jonathan Wakely via Gcc-patches
On 26/06/20 19:12 +0300, Ville Voutilainen via Libstdc++ wrote: This patch also deprecates std::is_literal_type. 2020-06-26 Ville Voutilainen PR libstdc++/95915 * include/std/type_traits (is_literal_type, is_literal_type_v): Deprecate in C++17. * include/std/variant

Re: [PATCH] libstdc++: std::variant doesn't like types with a defaulted virtual destructor [PR95915]

2020-06-26 Thread Ville Voutilainen via Gcc-patches
On Fri, 26 Jun 2020 at 19:12, Ville Voutilainen wrote: > > This patch also deprecates std::is_literal_type. I forgot to ask, OK for trunk and GCC 10 if full suite testing passes? The problematic compiler bug has been gone since GCC 10, so we can just as well backport this there, but not further.

[PATCH] libstdc++: std::variant doesn't like types with a defaulted virtual destructor [PR95915]

2020-06-26 Thread Ville Voutilainen via Gcc-patches
This patch also deprecates std::is_literal_type. 2020-06-26 Ville Voutilainen PR libstdc++/95915 * include/std/type_traits (is_literal_type, is_literal_type_v): Deprecate in C++17. * include/std/variant (_Uninitialized): Adjust the condition and the comment. *