Re: [PATCH] libstdc++: use __bool_constant instead of integral_constant

Thank you! On Wed, May 17, 2023 at 8:53 AM Patrick Palka wrote: > > On Fri, 12 May 2023, Ken Matsui via Libstdc++ wrote: > > > It appears that GCC 13 has been released, but I am wondering if there > > are any issues preventing this patch from being merged yet. Can you > > provide any information

Re: [PATCH] libstdc++: use __bool_constant instead of integral_constant

On Fri, 12 May 2023, Ken Matsui via Libstdc++ wrote: > It appears that GCC 13 has been released, but I am wondering if there > are any issues preventing this patch from being merged yet. Can you > provide any information on this? Thanks for the reminder, I pushed this to trunk just now (r14-940-g

Re: [PATCH] libstdc++: use __bool_constant instead of integral_constant

It appears that GCC 13 has been released, but I am wondering if there are any issues preventing this patch from being merged yet. Can you provide any information on this? On Sat, Apr 8, 2023 at 2:08 PM Ken Matsui wrote: > > I see. Thank you! > > On Sat, Apr 8, 2023 at 12:52 AM Jonathan Wakely wr

Re: [PATCH] libstdc++: use __bool_constant instead of integral_constant

I see. Thank you! On Sat, Apr 8, 2023 at 12:52 AM Jonathan Wakely wrote: > > This looks good, thanks, but we're too close to the gcc 13 release now, and > this isn't fixing any bugs. I'll push it after the release. > > > On Thu, 23 Mar 2023, 11:07 Ken Matsui via Libstdc++, > wrote: >> >> In th

Re: [PATCH] libstdc++: use __bool_constant instead of integral_constant

This looks good, thanks, but we're too close to the gcc 13 release now, and this isn't fixing any bugs. I'll push it after the release. On Thu, 23 Mar 2023, 11:07 Ken Matsui via Libstdc++, wrote: > In the type_traits header, both integral_constant and __bool_constant > are used. This patch unif

PING: [PATCH] libstdc++: use __bool_constant instead of integral_constant

Ping for this patch. On Thu, Mar 23, 2023 at 4:06 AM Ken Matsui wrote: > > In the type_traits header, both integral_constant and __bool_constant > are used. This patch unifies those usages into __bool_constant. > > libstdc++-v3/ChangeLog: > > * include/std/type_traits: Use __bool_constant

[PATCH] libstdc++: use __bool_constant instead of integral_constant

In the type_traits header, both integral_constant and __bool_constant are used. This patch unifies those usages into __bool_constant. libstdc++-v3/ChangeLog: * include/std/type_traits: Use __bool_constant instead of integral_constant. Signed-off-by: Ken Matsui --- libstdc++-v3/

Re: [PATCH] libstdc++: use __bool_constant instead of integral_constant

On Thu, Mar 23, 2023 at 3:56 AM Ville Voutilainen wrote: > > On Thu, 23 Mar 2023 at 12:53, Ken Matsui wrote: > > > > DCO sign-off is indeed more light-weight, and sure, it's becoming more > > > common > > > since it's relatively new as an option. > > > > Thank you! > > > > To add a DCO sign-off,

Re: [PATCH] libstdc++: use __bool_constant instead of integral_constant

On Thu, 23 Mar 2023 at 12:53, Ken Matsui wrote: > > DCO sign-off is indeed more light-weight, and sure, it's becoming more > > common > > since it's relatively new as an option. > > Thank you! > > To add a DCO sign-off, do I need to bump up the subject line to [PATCH v2]? No. The format of the

Re: [PATCH] libstdc++: use __bool_constant instead of integral_constant

On Thu, Mar 23, 2023 at 3:46 AM Ville Voutilainen wrote: > > On Thu, 23 Mar 2023 at 12:18, Ken Matsui via Libstdc++ > wrote: > > > > Thank you so much for your review! > > > > This is my first time contributing to GCC, so I do not have a GCC > > copyright assignment. I googled those two ways, but

Re: [PATCH] libstdc++: use __bool_constant instead of integral_constant

On Thu, 23 Mar 2023 at 12:18, Ken Matsui via Libstdc++ wrote: > > Thank you so much for your review! > > This is my first time contributing to GCC, so I do not have a GCC > copyright assignment. I googled those two ways, but I am still > confused... Is it correct that the DCO sign-off has been get

Re: [PATCH] libstdc++: use __bool_constant instead of integral_constant

Thank you so much for your review! This is my first time contributing to GCC, so I do not have a GCC copyright assignment. I googled those two ways, but I am still confused... Is it correct that the DCO sign-off has been getting more common recently? If so, I will put the sign-off into all my patc

Re: [PATCH] libstdc++: use __bool_constant instead of integral_constant

On Thu, 23 Mar 2023 at 02:06, Ken Matsui via Libstdc++ < libstd...@gcc.gnu.org> wrote: > In the type_traits header, both integral_constant and __bool_constant > are used. Yes, this is just because we didn't have __bool_constant originally, and nobody has needed to touch the traits that still use

[PATCH] libstdc++: use __bool_constant instead of integral_constant

In the type_traits header, both integral_constant and __bool_constant are used. This patch unifies those usages into __bool_constant. libstdc++-v3/ChangeLog: * include/std/type_traits: Use __bool_constant instead of integral_constant. --- libstdc++-v3/include/std/type_traits | 32