Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-14 Thread Szabolcs Nagy
On 13/08/18 19:57, Jonathan Wakely wrote: On 13/08/18 13:04 +0100, Jonathan Wakely wrote: On 13/08/18 12:55 +0100, Szabolcs Nagy wrote: On 09/08/18 10:08, Jonathan Wakely wrote: Yes please, on trunk and 7 and 8. It's better to use the standard aligned_alloc if available. but the newlib

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-13 Thread Jonathan Wakely
On 13/08/18 13:04 +0100, Jonathan Wakely wrote: On 13/08/18 12:55 +0100, Szabolcs Nagy wrote: On 09/08/18 10:08, Jonathan Wakely wrote: On 09/08/18 06:56 +0200, Sebastian Huber wrote: On 08/08/18 16:33, Jonathan Wakely wrote: On 08/08/18 16:22 +0200, Ulrich Weigand wrote: Jonathan Wakely

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-13 Thread Jonathan Wakely
On 13/08/18 12:55 +0100, Szabolcs Nagy wrote: On 09/08/18 10:08, Jonathan Wakely wrote: On 09/08/18 06:56 +0200, Sebastian Huber wrote: On 08/08/18 16:33, Jonathan Wakely wrote: On 08/08/18 16:22 +0200, Ulrich Weigand wrote: Jonathan Wakely wrote: Aha, so newlib was using memalign

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-13 Thread Szabolcs Nagy
On 09/08/18 10:08, Jonathan Wakely wrote: On 09/08/18 06:56 +0200, Sebastian Huber wrote: On 08/08/18 16:33, Jonathan Wakely wrote: On 08/08/18 16:22 +0200, Ulrich Weigand wrote: Jonathan Wakely wrote: Aha, so newlib was using memalign previously: @@ -53,20 +54,24 @@ aligned_alloc

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-09 Thread Rainer Orth
Hi Jonathan, > Committed to trunk, gcc-8-branch and gcc-7-branch. > > Rainer, please let me know if this still works on Solaris 10, thanks. I ran i386-pc-solaris2.1[01] and sparc-sun-solaris2.1[01] bootstraps last night: no regressions. Thanks. Rainer --

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-09 Thread Jonathan Wakely
On 09/08/18 06:56 +0200, Sebastian Huber wrote: On 08/08/18 16:33, Jonathan Wakely wrote: On 08/08/18 16:22 +0200, Ulrich Weigand wrote: Jonathan Wakely wrote: Aha, so newlib was using memalign previously: @@ -53,20 +54,24 @@ aligned_alloc (std::size_t al, std::size_t sz)  #else  extern "C"

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-08 Thread Sebastian Huber
On 08/08/18 16:33, Jonathan Wakely wrote: On 08/08/18 16:22 +0200, Ulrich Weigand wrote: Jonathan Wakely wrote: Aha, so newlib was using memalign previously: @@ -53,20 +54,24 @@ aligned_alloc (std::size_t al, std::size_t sz)  #else  extern "C" void *memalign(std::size_t boundary, std::size_t

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-08 Thread Jonathan Wakely
On 08/08/18 15:46 +0100, Jonathan Wakely wrote: On 08/08/18 15:33 +0100, Jonathan Wakely wrote: On 08/08/18 16:22 +0200, Ulrich Weigand wrote: Jonathan Wakely wrote: Aha, so newlib was using memalign previously: @@ -53,20 +54,24 @@ aligned_alloc (std::size_t al, std::size_t sz) #else extern

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-08 Thread Jonathan Wakely
On 08/08/18 15:33 +0100, Jonathan Wakely wrote: On 08/08/18 16:22 +0200, Ulrich Weigand wrote: Jonathan Wakely wrote: Aha, so newlib was using memalign previously: @@ -53,20 +54,24 @@ aligned_alloc (std::size_t al, std::size_t sz) #else extern "C" void *memalign(std::size_t boundary,

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-08 Thread Jonathan Wakely
On 08/08/18 16:22 +0200, Ulrich Weigand wrote: Jonathan Wakely wrote: Aha, so newlib was using memalign previously: @@ -53,20 +54,24 @@ aligned_alloc (std::size_t al, std::size_t sz) #else extern "C" void *memalign(std::size_t boundary, std::size_t size); #endif -#define aligned_alloc

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-08 Thread Ulrich Weigand
Jonathan Wakely wrote: > Aha, so newlib was using memalign previously: > > @@ -53,20 +54,24 @@ aligned_alloc (std::size_t al, std::size_t sz) > #else > extern "C" void *memalign(std::size_t boundary, std::size_t size); > #endif > -#define aligned_alloc memalign Yes, exactly ... this commit

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-08 Thread Jonathan Wakely
On 08/08/18 16:04 +0200, Sebastian Huber wrote: On 08/08/18 16:01, Jonathan Wakely wrote: On 08/08/18 15:57 +0200, Ulrich Weigand wrote: Jonathan Wakely wrote: On 08/08/18 10:52 +0200, Sebastian Huber wrote: While building for Newlib, some configure checks must be hard coded. The

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-08 Thread Sebastian Huber
On 08/08/18 16:01, Jonathan Wakely wrote: On 08/08/18 15:57 +0200, Ulrich Weigand wrote: Jonathan Wakely wrote: On 08/08/18 10:52 +0200, Sebastian Huber wrote: >While building for Newlib, some configure checks must be hard coded. >The aligned_alloc() is supported since 2015 in Newlib. >

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-08 Thread Jonathan Wakely
On 08/08/18 15:57 +0200, Ulrich Weigand wrote: Jonathan Wakely wrote: On 08/08/18 10:52 +0200, Sebastian Huber wrote: >While building for Newlib, some configure checks must be hard coded. >The aligned_alloc() is supported since 2015 in Newlib. > >libstdc++-v3 > >PR target/85904 >*

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-08 Thread Ulrich Weigand
Jonathan Wakely wrote: > On 08/08/18 10:52 +0200, Sebastian Huber wrote: > >While building for Newlib, some configure checks must be hard coded. > >The aligned_alloc() is supported since 2015 in Newlib. > > > >libstdc++-v3 > > > > PR target/85904 > > * configure.ac): Define

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-08 Thread Sebastian Huber
On 08/08/18 13:18, Jonathan Wakely wrote: On 08/08/18 10:52 +0200, Sebastian Huber wrote: While building for Newlib, some configure checks must be hard coded. The aligned_alloc() is supported since 2015 in Newlib. libstdc++-v3 PR target/85904 * configure.ac): Define HAVE_ALIGNED_ALLOC

Re: [PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-08 Thread Jonathan Wakely
On 08/08/18 10:52 +0200, Sebastian Huber wrote: While building for Newlib, some configure checks must be hard coded. The aligned_alloc() is supported since 2015 in Newlib. libstdc++-v3 PR target/85904 * configure.ac): Define HAVE_ALIGNED_ALLOC if building for There's a stray

[PATCH] libstdc++-v3: Have aligned_alloc() on Newlib

2018-08-08 Thread Sebastian Huber
While building for Newlib, some configure checks must be hard coded. The aligned_alloc() is supported since 2015 in Newlib. libstdc++-v3 PR target/85904 * configure.ac): Define HAVE_ALIGNED_ALLOC if building for Newlib. * configure: Regnerate. ---