Re: [PATCH] lto: fix LTO debug sections copying.

2020-10-06 Thread Martin Liška
On 10/6/20 7:34 PM, Ian Lance Taylor wrote: On Tue, Oct 6, 2020 at 3:20 AM Martin Liška wrote: On 10/6/20 10:00 AM, Richard Biener wrote: On Tue, Oct 6, 2020 at 9:01 AM Martin Liška wrote: On 10/5/20 6:34 PM, Ian Lance Taylor wrote: On Mon, Oct 5, 2020 at 9:09 AM Martin Liška wrote: Th

Re: [PATCH] lto: fix LTO debug sections copying.

2020-10-06 Thread Ian Lance Taylor via Gcc-patches
On Tue, Oct 6, 2020 at 3:20 AM Martin Liška wrote: > > On 10/6/20 10:00 AM, Richard Biener wrote: > > On Tue, Oct 6, 2020 at 9:01 AM Martin Liška wrote: > >> > >> On 10/5/20 6:34 PM, Ian Lance Taylor wrote: > >>> On Mon, Oct 5, 2020 at 9:09 AM Martin Liška wrote: > > The previous patch

Re: [PATCH] lto: fix LTO debug sections copying.

2020-10-06 Thread Jakub Jelinek via Gcc-patches
On Tue, Oct 06, 2020 at 12:20:14PM +0200, Martin Liška wrote: > On 10/6/20 10:00 AM, Richard Biener wrote: > > On Tue, Oct 6, 2020 at 9:01 AM Martin Liška wrote: > > > > > > On 10/5/20 6:34 PM, Ian Lance Taylor wrote: > > > > On Mon, Oct 5, 2020 at 9:09 AM Martin Liška wrote: > > > > > > > > >

Re: [PATCH] lto: fix LTO debug sections copying.

2020-10-06 Thread Martin Liška
eedback from Richi. Thanks, Martin Thanks. Ian >From bb259b4dc2a79ef45d449896d05855122ecc2ef9 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Mon, 5 Oct 2020 18:03:08 +0200 Subject: [PATCH] lto: fix LTO debug sections copying. readelf -S prints: There are 81999 section headers, s

Re: [PATCH] lto: fix LTO debug sections copying.

2020-10-06 Thread Richard Biener via Gcc-patches
On Tue, Oct 6, 2020 at 9:01 AM Martin Liška wrote: > > On 10/5/20 6:34 PM, Ian Lance Taylor wrote: > > On Mon, Oct 5, 2020 at 9:09 AM Martin Liška wrote: > >> > >> The previous patch was not correct. This one should be. > >> > >> Ready for master? > > > > I don't understand why this code uses sym

Re: [PATCH] lto: fix LTO debug sections copying.

2020-10-06 Thread Martin Liška
On 10/5/20 6:34 PM, Ian Lance Taylor wrote: On Mon, Oct 5, 2020 at 9:09 AM Martin Liška wrote: The previous patch was not correct. This one should be. Ready for master? I don't understand why this code uses symtab_indices_shndx at all. There should only be one SHT_SYMTAB_SHNDX section. The

Re: [PATCH] lto: fix LTO debug sections copying.

2020-10-05 Thread Ian Lance Taylor via Gcc-patches
On Mon, Oct 5, 2020 at 9:09 AM Martin Liška wrote: > > The previous patch was not correct. This one should be. > > Ready for master? I don't understand why this code uses symtab_indices_shndx at all. There should only be one SHT_SYMTAB_SHNDX section. There shouldn't be any need for the symtab_in

Re: [PATCH] lto: fix LTO debug sections copying.

2020-10-05 Thread Martin Liška
Hi. The previous patch was not correct. This one should be. Ready for master? Thanks, Martin >From a96f7ae39b5d56ce886edf1bfb9ca6475a857652 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Mon, 5 Oct 2020 18:03:08 +0200 Subject: [PATCH] lto: fix LTO debug sections copying. MIME-Version:

Re: [PATCH] lto: fix LTO debug sections copying.

2020-10-05 Thread Martin Liška
Adding Ian (and Richi) to CC. On 10/5/20 5:20 PM, Martin Liška wrote: As seen in the PR, we get to situation where we have a big number of symbols (~125K) and thus we reach .symtab_shndx section usage. For .symtab we get the following sh_link: (gdb) p strtab $1 = 81997 readelf -S prints: Ther

[PATCH] lto: fix LTO debug sections copying.

2020-10-05 Thread Martin Liška
As seen in the PR, we get to situation where we have a big number of symbols (~125K) and thus we reach .symtab_shndx section usage. For .symtab we get the following sh_link: (gdb) p strtab $1 = 81997 readelf -S prints: There are 81999 section headers, starting at offset 0x1f488060: Section Hea