Re: [PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack

On 6/20/24 4:36 PM, Richard Biener wrote: Am 20.06.2024 um 16:05 schrieb Andrew MacLeod :  On 6/20/24 05:31, Richard Biener wrote: On Thu, 20 Jun 2024, Aldy Hernandez wrote: Hi. I came around to this, and whipped up the proposed patch. However, it does seem a bit verbose, and I'm wond

Re: [PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack

> Am 20.06.2024 um 16:05 schrieb Andrew MacLeod : > >  >> On 6/20/24 05:31, Richard Biener wrote: >>> On Thu, 20 Jun 2024, Aldy Hernandez wrote: >>> >>> Hi. >>> >>> I came around to this, and whipped up the proposed patch. However, it >>> does seem a bit verbose, and I'm wondering if it's c

Re: [PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack

On 6/20/24 05:31, Richard Biener wrote: On Thu, 20 Jun 2024, Aldy Hernandez wrote: Hi. I came around to this, and whipped up the proposed patch. However, it does seem a bit verbose, and I'm wondering if it's cleaner to just leave things as they are. The attached patch passes tests and ther

Re: [PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack

On Thu, 20 Jun 2024, Aldy Hernandez wrote: > Hi. > > I came around to this, and whipped up the proposed patch. However, it > does seem a bit verbose, and I'm wondering if it's cleaner to just > leave things as they are. > > The attached patch passes tests and there's no difference in > performa

Re: [PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack

Hi. I came around to this, and whipped up the proposed patch. However, it does seem a bit verbose, and I'm wondering if it's cleaner to just leave things as they are. The attached patch passes tests and there's no difference in performance. I am wondering, whether it's better to get rid of all/

Re: [PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack

On Tue, 9 Apr 2024, Aldy Hernandez wrote: > BTW, I'm not opposed to this patch. Thank you for tracking this down, > and feel free to commit as is if y'all PMs agree it's OK. I just > wanted to know if there's a better way going forward. I can certainly > put it on my TODO list once stage1 opens

Re: [PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack

BTW, I'm not opposed to this patch. Thank you for tracking this down, and feel free to commit as is if y'all PMs agree it's OK. I just wanted to know if there's a better way going forward. I can certainly put it on my TODO list once stage1 opens again. And no, there probably isn't an obstack fo

Re: [PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack

> Am 08.04.2024 um 18:40 schrieb Aldy Hernandez : > > On Mon, Apr 8, 2024 at 6:29 PM Richard Biener wrote: >> >> >> Am 08.04.2024 um 18:09 schrieb Aldy Hernandez : >>> >>> On Mon, Apr 8, 2024 at 5:54 PM Jakub Jelinek wrote: On Mon, Apr 08, 2024 at 05:40:23PM +0200, Aldy

Re: [PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack

On Mon, Apr 8, 2024 at 6:29 PM Richard Biener wrote: > > > > > Am 08.04.2024 um 18:09 schrieb Aldy Hernandez : > > > > On Mon, Apr 8, 2024 at 5:54 PM Jakub Jelinek wrote: > >> > >> On Mon, Apr 08, 2024 at 05:40:23PM +0200, Aldy Hernandez wrote: > PR middle-end/114604 > *

Re: [PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack

> Am 08.04.2024 um 18:09 schrieb Aldy Hernandez : > > On Mon, Apr 8, 2024 at 5:54 PM Jakub Jelinek wrote: >> >> On Mon, Apr 08, 2024 at 05:40:23PM +0200, Aldy Hernandez wrote: PR middle-end/114604 * gimple-range.cc (enable_ranger): Initialize the global bi

Re: [PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack

On Mon, Apr 8, 2024 at 5:54 PM Jakub Jelinek wrote: > > On Mon, Apr 08, 2024 at 05:40:23PM +0200, Aldy Hernandez wrote: > > > PR middle-end/114604 > > > * gimple-range.cc (enable_ranger): Initialize the global > > > bitmap obstack. > > > (disable_ranger): Release it

Re: [PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack

On Mon, Apr 08, 2024 at 05:40:23PM +0200, Aldy Hernandez wrote: > > PR middle-end/114604 > > * gimple-range.cc (enable_ranger): Initialize the global > > bitmap obstack. > > (disable_ranger): Release it. > > --- > > gcc/gimple-range.cc | 4 > > 1 file changed,

Re: [PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack

On Mon, Apr 8, 2024 at 11:50 AM Richard Biener wrote: > > The following fixes ranger bitmap allocation when invoked from IPA > context where the global bitmap obstack possibly isn't initialized. > Instead of trying to use one of the ranger obstacks the following > simply initializes the global bit

[PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack

The following fixes ranger bitmap allocation when invoked from IPA context where the global bitmap obstack possibly isn't initialized. Instead of trying to use one of the ranger obstacks the following simply initializes the global bitmap obstack around an active ranger. Bootstrapped and tested on