Re: [PATCH] mklog: Add --append option to auto add generate ChangeLog to patch file

2023-07-21 Thread Lehua Ding
Hi Martin, Thank you for telling me about the Python code format specification. I'm no idea how to add checks for pushed commits. Anyway, first make sure I don't introduce new format errors myself. Best, Lehua

Re: [PATCH] mklog: Add --append option to auto add generate ChangeLog to patch file

2023-07-21 Thread Martin Jambor
Hello Lehua, On Fri, Jul 21 2023, Lehua Ding wrote: > Hi Martin, > > > By the way, is there a standard format required for these Python files? Generally, our Python coding conventions are at https://gcc.gnu.org/codingconventions.html#python > I see that other Python files have similar format

Re: [PATCH] mklog: Add --append option to auto add generate ChangeLog to patch file

2023-07-21 Thread Lehua Ding
Hi Martin, By the way, is there a standard format required for these Python files? I see that other Python files have similar format error when checked using flake8.If so, it feels necessary to configure a git hook on git server to do this check. Best, Lehua

Re: [PATCH] mklog: Add --append option to auto add generate ChangeLog to patch file

2023-07-21 Thread Lehua Ding
I am no python expert but the following seems to work: Thank you so much, it works for me. Lehua

Re: [PATCH] mklog: Add --append option to auto add generate ChangeLog to patch file

2023-07-21 Thread Martin Jambor
Hello Lehua, On Fri, Jul 21 2023, Lehua Ding wrote: > Hi Martin, > > > this patch caused flake8 to complain about contrib/mklog.py: > > $ flake8 contrib/mklog.py > contrib/mklog.py:377:80: E501 line too long (85 79 characters) > contrib/mklog.py:388:26: E127 continuation line over-indented

Re: [PATCH] mklog: Add --append option to auto add generate ChangeLog to patch file

2023-07-21 Thread Lehua Ding
Hi Martin, this patch caused flake8 to complain about contrib/mklog.py: $ flake8 contrib/mklog.py contrib/mklog.py:377:80: E501 line too long (85 79 characters) contrib/mklog.py:388:26: E127 continuation line over-indented for visual indent contrib/mklog.py:388:36: W605 invalid escape

Re: [PATCH] mklog: Add --append option to auto add generate ChangeLog to patch file

2023-07-21 Thread Martin Jambor
Hello Lehua, On Wed, Jul 12 2023, Lehua Ding wrote: > Hi, > > This tiny patch add --append option to mklog.py that support add generated > ChangeLog to the corresponding patch file. With this option there is no need > to manually copy the generated ChangeLog to the patch file. e.g.: > > Run

Re: [PATCH] mklog: Add --append option to auto add generate ChangeLog to patch file

2023-07-12 Thread Lehua Ding
Commited to the trunk, thanks Jeff. --Original-- From: "JeffLaw"

Re: [PATCH] mklog: Add --append option to auto add generate ChangeLog to patch file

2023-07-12 Thread Jeff Law via Gcc-patches
On 7/11/23 22:01, Lehua Ding wrote: Hi, This tiny patch add --append option to mklog.py that support add generated ChangeLog to the corresponding patch file. With this option there is no need to manually copy the generated ChangeLog to the patch file. e.g.: Run `mklog.py -a

[PATCH] mklog: Add --append option to auto add generate ChangeLog to patch file

2023-07-11 Thread Lehua Ding
Hi, This tiny patch add --append option to mklog.py that support add generated ChangeLog to the corresponding patch file. With this option there is no need to manually copy the generated ChangeLog to the patch file. e.g.: Run `mklog.py -a /path/to/this/patch` will add the generated ChangeLog