[PATCH] put exception tables for comdat functions in comdat, too

2012-08-05 Thread Sandra Loosemore
For C++ functions that are emitted to a comdat section (template instantiations and the like), the corresponding exception handling information is presently being emitted to the non-comdat .gcc_except_table section. This means that you can end up with multiple copies of the exception tables in

Re: [PATCH] put exception tables for comdat functions in comdat, too

2012-08-06 Thread Richard Henderson
On 08/05/2012 08:40 PM, Sandra Loosemore wrote: > 2012-08-04 Paul Brook > Sandra Loosemore > > gcc/ > * except.c (switch_to_exception_section): Place tables for > DECL_ONE_ONLY functions in comdat groups. Mostly ok. > - s = get_section (section_name, flags, NUL

Re: [PATCH] put exception tables for comdat functions in comdat, too

2012-08-06 Thread Sandra Loosemore
On 08/06/2012 11:45 AM, Richard Henderson wrote: On 08/05/2012 08:40 PM, Sandra Loosemore wrote: 2012-08-04 Paul Brook Sandra Loosemore gcc/ * except.c (switch_to_exception_section): Place tables for DECL_ONE_ONLY functions in comdat groups. Mostly ok. -

Re: [PATCH] put exception tables for comdat functions in comdat, too

2012-08-07 Thread Richard Henderson
On 08/06/2012 05:45 PM, Sandra Loosemore wrote: > OK to commit the patch as originally posted? Yes. I mis-read skimming the part of that function about relocations. r~