Eric,
This patch adds scanning of clobbers in CALL_INSN_FUNCTION_USAGE to
find_all_hard_reg_sets.
For MIPS, calls are split at some point. After the split, one of the resulting
insns may clobber $6. But before the split, that's not explicit in the rtl
representation of the unsplit call.
Fo
On 16-01-14 09:13, Richard Sandiford wrote:
Tom de Vries writes:
* The set of registers which are clobbered during a call by things like the plt
- these are not picked up by the use-caller-save optimization. We need the
hook to inform the compiler about these registers
Right, but...
On 15-01-14 17:53, Tom de Vries wrote:
Eric,
This patch adds scanning of clobbers in CALL_INSN_FUNCTION_USAGE to
find_all_hard_reg_sets.
For MIPS, calls are split at some point. After the split, one of the resulting
insns may clobber $6. But before the split, that's not explicit in the rtl
repr
Tom de Vries writes:
> On 16-01-14 09:13, Richard Sandiford wrote:
>> Tom de Vries writes:
>>> * The set of registers which are clobbered during a call by things
>>> like the plt
>>> - these are not picked up by the use-caller-save optimization. We
>>> need the
>>> hook to inform the comp
On 16/04/14 12:28, Richard Sandiford wrote:
>> > This patch introduces a hook that specifies which registers are implicitly
>> > clobbered by a call, not including the registers that are clobbered in the
>> > called function, and then uses that hook to add those registers to
>> > CALL_INSN_FUNCT
On Wed, Apr 16, 2014 at 11:46:14AM +0200, Tom de Vries wrote:
> >...why do we need two different mechanisms to deal with these two?
> >IMO the set recorded for the callee should contain what the callee
> >instructions clobber and nothing else. CALL_INSN_FUNCTION_USAGE
> >should contain everything
Jakub Jelinek writes:
> On Wed, Apr 16, 2014 at 11:46:14AM +0200, Tom de Vries wrote:
>> >...why do we need two different mechanisms to deal with these two?
>> >IMO the set recorded for the callee should contain what the callee
>> >instructions clobber and nothing else. CALL_INSN_FUNCTION_USAGE
>
Tom de Vries writes:
> On 16/04/14 12:28, Richard Sandiford wrote:
>>> > This patch introduces a hook that specifies which registers are
>>> > implicitly
>>> > clobbered by a call, not including the registers that are clobbered in
>>> > the
>>> > called function, and then uses that hook to add
Tom de Vries writes:
> This patch adds scanning of clobbers in CALL_INSN_FUNCTION_USAGE to
> find_all_hard_reg_sets.
>
> For MIPS, calls are split at some point. After the split, one of the
> resulting insns may clobber $6. But before the split, that's not
> explicit in the rtl representation of
On 15-01-14 19:40, Richard Sandiford wrote:
Tom de Vries writes:
This patch adds scanning of clobbers in CALL_INSN_FUNCTION_USAGE to
find_all_hard_reg_sets.
For MIPS, calls are split at some point. After the split, one of the
resulting insns may clobber $6. But before the split, that's not
exp
Tom de Vries writes:
> * The set of registers which are clobbered during a call by things like the
> plt
>- these are not picked up by the use-caller-save optimization. We need the
>hook to inform the compiler about these registers
Right, but...
> * And finally, registers clobbered in t
> Ping of this ( http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00888.html )
> patch.
That patch isn't for GCC mainline though, but OK on principle if you test it
on mainline, avoid the very ugly set-inside-use idiom and do:
record_hard_reg_sets (XEXP (op, 0), NULL, pset);
instead of reimplemen
On 22-04-14 21:27, Eric Botcazou wrote:
Ping of this ( http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00888.html )
patch.
Eric,
thanks for the review.
That patch isn't for GCC mainline though, but
I don't understand why you say that.
OK on principle if you test it
on mainline,
I have.
> I don't understand why you say that.
Because it cannot be applied on GCC mainline.
--
Eric Botcazou
On 23-04-14 00:03, Eric Botcazou wrote:
I don't understand why you say that.
Because it cannot be applied on GCC mainline.
Eric,
Ah, I see.
Indeed, the patch is dependent on approved patch 'Add implicit parameter to
find_all_hard_reg_sets' ( http://gcc.gnu.org/ml/gcc-patches/2013-03/msg01
15 matches
Mail list logo
