Re: [PATCH] reload: Handle generating reloads that also clobbers flags

2023-04-29 Thread Jeff Law via Gcc-patches
On 4/18/23 08:12, Hans-Peter Nilsson wrote: Date: Tue, 18 Apr 2023 07:43:41 -0600 From: Jeff Law On 2/15/23 08:34, Hans-Peter Nilsson via Gcc-patches wrote: Regtested cris-elf with its LEGITIMIZE_RELOAD_ADDRESS disabled, where it regresses gcc.target/cris/rld-legit1.c; as expected,

Re: [PATCH] reload: Handle generating reloads that also clobbers flags

2023-04-18 Thread Eric Botcazou via Gcc-patches
> That "supposed to" is only *one* possible implementation. > The one in CRIS - and I believe the preferred one; one I > should advocate more - is to *always* expose clobbering of > the flags. Yes, both approaches are acceptable IMO and should work. -- Eric Botcazou

Re: [PATCH] reload: Handle generating reloads that also clobbers flags

2023-04-18 Thread Hans-Peter Nilsson via Gcc-patches
> Date: Tue, 18 Apr 2023 07:43:41 -0600 > From: Jeff Law > On 2/15/23 08:34, Hans-Peter Nilsson via Gcc-patches wrote: > > Regtested cris-elf with its LEGITIMIZE_RELOAD_ADDRESS > > disabled, where it regresses gcc.target/cris/rld-legit1.c; > > as expected, because that test guards proper

Re: [PATCH] reload: Handle generating reloads that also clobbers flags

2023-04-18 Thread Jeff Law via Gcc-patches
On 2/15/23 08:34, Hans-Peter Nilsson via Gcc-patches wrote: Regtested cris-elf with its LEGITIMIZE_RELOAD_ADDRESS disabled, where it regresses gcc.target/cris/rld-legit1.c; as expected, because that test guards proper function of its LEGITIMIZE_RELOAD_ADDRESS i.e., that there's no sign of

[PATCH] reload: Handle generating reloads that also clobbers flags

2023-02-15 Thread Hans-Peter Nilsson via Gcc-patches
Regtested cris-elf with its LEGITIMIZE_RELOAD_ADDRESS disabled, where it regresses gcc.target/cris/rld-legit1.c; as expected, because that test guards proper function of its LEGITIMIZE_RELOAD_ADDRESS i.e., that there's no sign of decomposed address elements. LRA also causes a similar