Re: [PATCH] rs6000: Fix up easy_vector_constant_msb handling [PR101384]

2021-07-20 Thread Segher Boessenkool
On Tue, Jul 20, 2021 at 05:24:57PM +0200, Jakub Jelinek wrote: > On Tue, Jul 20, 2021 at 10:17:08AM -0500, Segher Boessenkool wrote: > > > I think not all of the -Wpsabi diagnostics is emitted with warning{,_at} > > > etc. that -w disables, others are emitted with inform. > > > > /* An informative

Re: [PATCH] rs6000: Fix up easy_vector_constant_msb handling [PR101384]

2021-07-20 Thread Jakub Jelinek via Gcc-patches
On Tue, Jul 20, 2021 at 10:17:08AM -0500, Segher Boessenkool wrote: > On Tue, Jul 20, 2021 at 05:01:00PM +0200, Jakub Jelinek wrote: > > On Tue, Jul 20, 2021 at 09:48:26AM -0500, Segher Boessenkool wrote: > > > > --- gcc/testsuite/gcc.dg/pr101384.c.jj 2021-07-13 13:45:42.971992584 > > > > +0200 >

Re: [PATCH] rs6000: Fix up easy_vector_constant_msb handling [PR101384]

2021-07-20 Thread Segher Boessenkool
On Tue, Jul 20, 2021 at 05:01:00PM +0200, Jakub Jelinek wrote: > On Tue, Jul 20, 2021 at 09:48:26AM -0500, Segher Boessenkool wrote: > > > --- gcc/testsuite/gcc.dg/pr101384.c.jj2021-07-13 13:45:42.971992584 > > > +0200 > > > +++ gcc/testsuite/gcc.dg/pr101384.c 2021-07-13 13:45:32.4271351

Re: [PATCH] rs6000: Fix up easy_vector_constant_msb handling [PR101384]

2021-07-20 Thread Jakub Jelinek via Gcc-patches
On Tue, Jul 20, 2021 at 09:48:26AM -0500, Segher Boessenkool wrote: > > - if (mode == V4SFmode) > > + switch (easy_altivec_constant (operands[1], mode)) > > { > > - mode = V4SImode; > > - dest = gen_lowpart (V4SImode, dest); > > +case 1: mode = V16QImode; break; > > +case 2

Re: [PATCH] rs6000: Fix up easy_vector_constant_msb handling [PR101384]

2021-07-20 Thread Segher Boessenkool
Hi! On Tue, Jul 13, 2021 at 09:30:43PM +0200, Jakub Jelinek wrote: > PR target/101384 > * config/rs6000/rs6000-protos.h (easy_altivec_constant): Change return > type from bool to int. > * config/rs6000/rs6000.c (vspltis_constant): Fix up handling the > EASY_VECTOR_MSB

Re: Patch ping (was Re: [PATCH] rs6000: Fix up easy_vector_constant_msb handling [PR101384])

2021-07-20 Thread Segher Boessenkool
Hi! On Tue, Jul 20, 2021 at 02:43:03PM +0200, Jakub Jelinek wrote: > For gcc 11, I've bootstrapped/regtested on powerpc64le-linux and > powerpc64-linux (the latter regtested -m32/-m64) also a simpler version > below, which restricts it to the case that the code handles properly. > > 2021-07-20 J

Patch ping (was Re: [PATCH] rs6000: Fix up easy_vector_constant_msb handling [PR101384])

2021-07-20 Thread Jakub Jelinek via Gcc-patches
On Tue, Jul 13, 2021 at 09:30:43PM +0200, Jakub Jelinek via Gcc-patches wrote: > The following gcc.dg/pr101384.c testcase is miscompiled on > powerpc64le-linux. > easy_altivec_constant has code to try construct vector constants with > different element sizes, perhaps different from CONST_VECTOR's m

[PATCH] rs6000: Fix up easy_vector_constant_msb handling [PR101384]

2021-07-13 Thread Jakub Jelinek via Gcc-patches
Hi! The following gcc.dg/pr101384.c testcase is miscompiled on powerpc64le-linux. easy_altivec_constant has code to try construct vector constants with different element sizes, perhaps different from CONST_VECTOR's mode. But as written, that works fine for vspltis[bhw] cases, but not for the vspl