Re: [PATCH] sccvn: Improve handling of load masked with integer constant [PR93582]

2020-03-03 Thread Richard Biener
On Mon, 2 Mar 2020, Jakub Jelinek wrote: > On Mon, Mar 02, 2020 at 12:46:30PM +0100, Richard Biener wrote: > > > + void *r = data.push_partial_def (pd, 0, prec); > > > + if (r == (void *) -1) > > > + return NULL_TREE; > > > + gcc_assert (r == NULL_TREE); >

Re: [PATCH] sccvn: Improve handling of load masked with integer constant [PR93582]

2020-03-02 Thread Jakub Jelinek
On Mon, Mar 02, 2020 at 03:54:36PM +0100, Jakub Jelinek wrote: > So, like this if it passes bootstrap/regtest? Bootstrapped/regtested successfully on x86_64-linux and i686-linux. > 2020-03-02 Jakub Jelinek > > PR tree-optimization/93582 > * tree-ssa-sccvn.h (vn_reference_lookup):

Re: [PATCH] sccvn: Improve handling of load masked with integer constant [PR93582]

2020-03-02 Thread Jakub Jelinek
On Mon, Mar 02, 2020 at 12:46:30PM +0100, Richard Biener wrote: > > + void *r = data.push_partial_def (pd, 0, prec); > > + if (r == (void *) -1) > > + return NULL_TREE; > > + gcc_assert (r == NULL_TREE); > > + } > > + pos += tz; >

Re: [PATCH] sccvn: Improve handling of load masked with integer constant [PR93582]

2020-03-02 Thread Richard Biener
On Fri, 28 Feb 2020, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR and discussed on IRC, the following patch is the > patch that fixes the originally reported issue. > We have there because of the premature bitfield comparison -> BIT_FIELD_REF > optimization: > s$s4_19 = 0; > s.s4 = s

[PATCH] sccvn: Improve handling of load masked with integer constant [PR93582]

2020-02-28 Thread Jakub Jelinek
Hi! As mentioned in the PR and discussed on IRC, the following patch is the patch that fixes the originally reported issue. We have there because of the premature bitfield comparison -> BIT_FIELD_REF optimization: s$s4_19 = 0; s.s4 = s$s4_19; _10 = BIT_FIELD_REF ; _13 = _10 & 8; and no oth