Re: [PATCH] strub: avoid lto inlining

2023-12-19 Thread Alexandre Oliva
On Dec 15, 2023, Richard Biener wrote: > I think __noipa__ is more complete and will make the libgcc functions appear > as black boxes to callers. I was hesitant to use __noipa__ because I thought it might disable relevant optimizations even when not using LTO, but it is likely safer in the

Re: [PATCH] strub: avoid lto inlining

2023-12-14 Thread Richard Biener
On Thu, Dec 14, 2023 at 8:53 PM Alexandre Oliva wrote: > > > The strub builtins are not suited for cross-unit inlining, they should > only be inlined by the builtin expanders, if at all. While testing on > sparc64, it occurred to me that, if libgcc was built with LTO enabled, > lto1 might inline

[PATCH] strub: avoid lto inlining

2023-12-14 Thread Alexandre Oliva
The strub builtins are not suited for cross-unit inlining, they should only be inlined by the builtin expanders, if at all. While testing on sparc64, it occurred to me that, if libgcc was built with LTO enabled, lto1 might inline them, and that would likely break things. So, make sure they're