Re: [PATCH] tree-sra: Do not refresh readonly decls (PR 100453)

2021-06-17 Thread Richard Biener
On Wed, 16 Jun 2021, Martin Jambor wrote: > Hi, > > On Wed, Jun 16 2021, Jakub Jelinek wrote: > > On Tue, Jun 15, 2021 at 06:11:27PM +0200, Richard Biener wrote: > >> >--- a/gcc/tree-sra.c > >> >+++ b/gcc/tree-sra.c > >> >@@ -915,6 +915,12 @@ create_access (tree expr, gimple *stmt, bool > >>

Re: [PATCH] tree-sra: Do not refresh readonly decls (PR 100453)

2021-06-16 Thread Martin Jambor
Hi, On Wed, Jun 16 2021, Jakub Jelinek wrote: > On Tue, Jun 15, 2021 at 06:11:27PM +0200, Richard Biener wrote: >> >--- a/gcc/tree-sra.c >> >+++ b/gcc/tree-sra.c >> >@@ -915,6 +915,12 @@ create_access (tree expr, gimple *stmt, bool >> >write) >> >if (!DECL_P (base) || !bitmap_bit_p

Re: [PATCH] tree-sra: Do not refresh readonly decls (PR 100453)

2021-06-16 Thread Martin Sebor via Gcc-patches
On 6/16/21 5:48 AM, Jakub Jelinek wrote: On Tue, Jun 15, 2021 at 06:11:27PM +0200, Richard Biener wrote: --- a/gcc/tree-sra.c +++ b/gcc/tree-sra.c @@ -915,6 +915,12 @@ create_access (tree expr, gimple *stmt, bool write) if (!DECL_P (base) || !bitmap_bit_p (candidate_bitmap, DECL_UID (base)))

Re: [PATCH] tree-sra: Do not refresh readonly decls (PR 100453)

2021-06-16 Thread Jeff Law via Gcc-patches
On 6/16/2021 4:00 AM, Richard Biener wrote: On Wed, 16 Jun 2021, Martin Jambor wrote: Hi Richi, On Tue, Jun 15 2021, Richard Biener wrote: On June 15, 2021 5:09:40 PM GMT+02:00, Martin Jambor wrote: Hi, When SRA transforms an assignment where the RHS is an aggregate decl that it

Re: [PATCH] tree-sra: Do not refresh readonly decls (PR 100453)

2021-06-16 Thread Jakub Jelinek via Gcc-patches
On Tue, Jun 15, 2021 at 06:11:27PM +0200, Richard Biener wrote: > >--- a/gcc/tree-sra.c > >+++ b/gcc/tree-sra.c > >@@ -915,6 +915,12 @@ create_access (tree expr, gimple *stmt, bool > >write) > >if (!DECL_P (base) || !bitmap_bit_p (candidate_bitmap, DECL_UID > >(base))) > > return NULL; > > >

Re: [PATCH] tree-sra: Do not refresh readonly decls (PR 100453)

2021-06-16 Thread Richard Biener
On Wed, 16 Jun 2021, Martin Jambor wrote: > Hi Richi, > > On Tue, Jun 15 2021, Richard Biener wrote: > > On June 15, 2021 5:09:40 PM GMT+02:00, Martin Jambor > > wrote: > >>Hi, > >> > >>When SRA transforms an assignment where the RHS is an aggregate decl > >>that it creates replacements for,

Re: [PATCH] tree-sra: Do not refresh readonly decls (PR 100453)

2021-06-16 Thread Martin Jambor
Hi Richi, On Tue, Jun 15 2021, Richard Biener wrote: > On June 15, 2021 5:09:40 PM GMT+02:00, Martin Jambor wrote: >>Hi, >> >>When SRA transforms an assignment where the RHS is an aggregate decl >>that it creates replacements for, the (least efficient) fallback method >>of dealing with them is

Re: [PATCH] tree-sra: Do not refresh readonly decls (PR 100453)

2021-06-15 Thread Richard Biener
On June 15, 2021 5:09:40 PM GMT+02:00, Martin Jambor wrote: >Hi, > >When SRA transforms an assignment where the RHS is an aggregate decl >that it creates replacements for, the (least efficient) fallback method >of dealing with them is to store all the replacements back into the >original decl and

[PATCH] tree-sra: Do not refresh readonly decls (PR 100453)

2021-06-15 Thread Martin Jambor
Hi, When SRA transforms an assignment where the RHS is an aggregate decl that it creates replacements for, the (least efficient) fallback method of dealing with them is to store all the replacements back into the original decl and then let the original assignment takes its course. That of course