Re: [PATCH] vect: Remove vec_outside/inside_cost fields

2021-11-11 Thread Jan Hubicka via Gcc-patches
> > Now afunc writes to __var_5_mma only indirectly so I think it is correct > > that > > we optimize the conditional out. > > > > Easy fix would be to add -fno-ipa-modref, but perhaps someone with > > better understanding of Fortran would help me to improve the testcase so > > the calls to matmul

Re: [PATCH] vect: Remove vec_outside/inside_cost fields

2021-11-11 Thread Richard Biener via Gcc-patches
On Thu, Nov 11, 2021 at 10:45 AM Jan Hubicka via Gcc-patches wrote: > > > > > > > > > I think the patch causes the following on x86_64-linux-gnu: > > > > FAIL: gfortran.dg/inline_matmul_17.f90 -O scan-tree-dump-times > > > > optimized "matmul_r4" 2 > > > > > > I get that failure even with d70

Re: [PATCH] vect: Remove vec_outside/inside_cost fields

2021-11-11 Thread Jan Hubicka via Gcc-patches
> > > > > > I think the patch causes the following on x86_64-linux-gnu: > > > FAIL: gfortran.dg/inline_matmul_17.f90 -O scan-tree-dump-times > > > optimized "matmul_r4" 2 > > > > I get that failure even with d70ef65692f (from before the patches > > I committed today). > > Sorry, you are rig

Re: [PATCH] vect: Remove vec_outside/inside_cost fields

2021-11-11 Thread Martin Liška
On 11/10/21 18:18, Richard Sandiford wrote: Martin Liška writes: On 11/8/21 11:43, Richard Sandiford via Gcc-patches wrote: |Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install?| I think the patch causes the following on x86_64-linux-gnu: FAIL: gfortran.dg/inline_matmul_17.f90

Re: [PATCH] vect: Remove vec_outside/inside_cost fields

2021-11-10 Thread Richard Sandiford via Gcc-patches
Martin Liška writes: > On 11/8/21 11:43, Richard Sandiford via Gcc-patches wrote: >> |Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install?| > > I think the patch causes the following on x86_64-linux-gnu: > FAIL: gfortran.dg/inline_matmul_17.f90 -O scan-tree-dump-times optimized >

Re: [PATCH] vect: Remove vec_outside/inside_cost fields

2021-11-10 Thread Martin Liška
On 11/8/21 11:43, Richard Sandiford via Gcc-patches wrote: |Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install?| I think the patch causes the following on x86_64-linux-gnu: FAIL: gfortran.dg/inline_matmul_17.f90 -O scan-tree-dump-times optimized "matmul_r4" 2 Martin

Re: [PATCH] vect: Remove vec_outside/inside_cost fields

2021-11-08 Thread Richard Biener via Gcc-patches
On Mon, Nov 8, 2021 at 11:44 AM Richard Sandiford via Gcc-patches wrote: > > The vector costs now use a common base class instead of being > completely abstract. This means that there's no longer a > need to record the inside and outside costs separately. > > Tested on aarch64-linux-gnu and x86_6

[PATCH] vect: Remove vec_outside/inside_cost fields

2021-11-08 Thread Richard Sandiford via Gcc-patches
The vector costs now use a common base class instead of being completely abstract. This means that there's no longer a need to record the inside and outside costs separately. Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install? Richard gcc/ * tree-vectorizer.h (_loop_vec_i