Re: PING^2: [PATCH] x86: Add UNSPECV_PATCHABLE_AREA

2020-06-16 Thread H.J. Lu via Gcc-patches
On Tue, Jun 16, 2020 at 7:17 AM Jakub Jelinek wrote: > > On Tue, Jun 09, 2020 at 09:34:01AM -0700, H.J. Lu via Gcc-patches wrote: > > > > * gcc.target/i386/pr93492-3.c: Likewise. > > > > * gcc.target/i386/pr93492-5.c: Likewise. > > These tests FAIL on i686-linux. > E.g. in the

Re: PING^2: [PATCH] x86: Add UNSPECV_PATCHABLE_AREA

2020-06-16 Thread Jakub Jelinek via Gcc-patches
On Tue, Jun 09, 2020 at 09:34:01AM -0700, H.J. Lu via Gcc-patches wrote: > > > * gcc.target/i386/pr93492-3.c: Likewise. > > > * gcc.target/i386/pr93492-5.c: Likewise. These tests FAIL on i686-linux. E.g. in the first one I see .file "pr93492-3.c" .text

Re: [PATCH] x86: Add UNSPECV_PATCHABLE_AREA

2020-06-11 Thread Jeff Law via Gcc-patches
On Sat, 2020-05-02 at 04:55 -0700, H.J. Lu wrote: > Currently patchable area is at the wrong place. It is placed immediately > after function label, before both .cfi_startproc and ENDBR. This patch > adds UNSPECV_PATCHABLE_AREA for pseudo patchable area instruction and > changes ENDBR insertion

PING^2: [PATCH] x86: Add UNSPECV_PATCHABLE_AREA

2020-06-09 Thread H.J. Lu via Gcc-patches
On Fri, May 22, 2020 at 4:22 AM H.J. Lu wrote: > > On Sat, May 2, 2020 at 4:55 AM H.J. Lu wrote: > > > > Currently patchable area is at the wrong place. It is placed immediately > > after function label, before both .cfi_startproc and ENDBR. This patch > > adds UNSPECV_PATCHABLE_AREA for

PING: [PATCH] x86: Add UNSPECV_PATCHABLE_AREA

2020-05-22 Thread H.J. Lu via Gcc-patches
On Sat, May 2, 2020 at 4:55 AM H.J. Lu wrote: > > Currently patchable area is at the wrong place. It is placed immediately > after function label, before both .cfi_startproc and ENDBR. This patch > adds UNSPECV_PATCHABLE_AREA for pseudo patchable area instruction and > changes ENDBR insertion

[PATCH] x86: Add UNSPECV_PATCHABLE_AREA

2020-05-02 Thread H.J. Lu via Gcc-patches
Currently patchable area is at the wrong place. It is placed immediately after function label, before both .cfi_startproc and ENDBR. This patch adds UNSPECV_PATCHABLE_AREA for pseudo patchable area instruction and changes ENDBR insertion pass to also insert patchable area instruction.

[PATCH] x86: Add UNSPECV_PATCHABLE_AREA

2020-02-04 Thread H.J. Lu
On Mon, Feb 03, 2020 at 06:10:49PM -0800, H.J. Lu wrote: > On Mon, Feb 3, 2020 at 4:02 PM H.J. Lu wrote: > > > > On Mon, Feb 3, 2020 at 10:35 AM H.J. Lu wrote: > > > > > > Define TARGET_ASM_PRINT_PATCHABLE_FUNCTION_ENTRY to make sure that the > > > ENDBR are emitted before the patch area. When