[PATCH] x86: Enable FMA in rsqrt2 expander

2020-06-28 Thread H.J. Lu via Gcc-patches
Enable FMA in rsqrt2 expander and fold rsqrtv16sf2 expander into rsqrt2 expander which expands to UNSPEC_RSQRT28 for TARGET_AVX512ER. Although it doesn't show performance change in our workloads, FMA can improve other workloads. gcc/ PR target/88713 * config/i386/i386-expand.c (ix

Re: [PATCH] x86: Enable FMA in rsqrt2 expander

2020-07-07 Thread Kirill Yukhin via Gcc-patches
Hello HJ, On 28 июн 07:19, H.J. Lu via Gcc-patches wrote: > Enable FMA in rsqrt2 expander and fold rsqrtv16sf2 expander into > rsqrt2 expander which expands to UNSPEC_RSQRT28 for TARGET_AVX512ER. > Although it doesn't show performance change in our workloads, FMA can > improve other workloads. >

Re: [PATCH] x86: Enable FMA in rsqrt2 expander

2020-07-07 Thread H.J. Lu via Gcc-patches
On Tue, Jul 7, 2020 at 8:56 AM Kirill Yukhin wrote: > > Hello HJ, > > On 28 июн 07:19, H.J. Lu via Gcc-patches wrote: > > Enable FMA in rsqrt2 expander and fold rsqrtv16sf2 expander into > > rsqrt2 expander which expands to UNSPEC_RSQRT28 for TARGET_AVX512ER. > > Although it doesn't show performan

Re: [PATCH] x86: Enable FMA in rsqrt2 expander

2020-07-09 Thread Kirill Yukhin via Gcc-patches
On 07 июл 09:06, H.J. Lu wrote: > On Tue, Jul 7, 2020 at 8:56 AM Kirill Yukhin wrote: > > > > Hello HJ, > > > > On 28 июн 07:19, H.J. Lu via Gcc-patches wrote: > > > Enable FMA in rsqrt2 expander and fold rsqrtv16sf2 expander into > > > rsqrt2 expander which expands to UNSPEC_RSQRT28 for TARGET_AV

Re: [PATCH] x86: Enable FMA in rsqrt2 expander

2020-07-09 Thread H.J. Lu via Gcc-patches
> --- /dev/null > +++ b/gcc/testsuite/gcc.target/i386/pr88713-1.c > @@ -0,0 +1,13 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -Ofast -mno-avx512f -mfma" } */ > > I gues -O2 is useless here (and in -2.c test). Fixed. > Othwerwise LGTM. > This is t