Re: [PATCH (6/7)] More widening multiply-and-accumulate pattern matching

2011-10-13 Thread Matthew Gretton-Dann
This patch seems to have caused PR50717: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50717 Thanks, Matt On 19/08/11 15:49, Andrew Stubbs wrote: On 14/07/11 15:35, Richard Guenther wrote: Ok. I've just committed this updated patch. I found bugs with VOIDmode constants that have caused me

Re: [PATCH (6/7)] More widening multiply-and-accumulate pattern matching

2011-08-19 Thread Andrew Stubbs
On 14/07/11 15:35, Richard Guenther wrote: Ok. I've just committed this updated patch. I found bugs with VOIDmode constants that have caused me to recast my patches to is_widening_mult_rhs_p. They should be logically the same for non VOIDmode cases, but work correctly for constants. I think

Re: [PATCH (6/7)] More widening multiply-and-accumulate pattern matching

2011-07-14 Thread Andrew Stubbs
On 07/07/11 11:13, Richard Guenther wrote: This updates the context changed by my update to patch 3. The content of this patch has not changed. Ok. I know this patch was already approved, but I discovered a bug in this patch that missed optimizing the case where the input to multiply did

Re: [PATCH (6/7)] More widening multiply-and-accumulate pattern matching

2011-07-14 Thread Richard Guenther
On Thu, Jul 14, 2011 at 4:34 PM, Andrew Stubbs a...@codesourcery.com wrote: On 07/07/11 11:13, Richard Guenther wrote: This updates the context changed by my update to patch 3.  The content of this patch has not changed. Ok. I know this patch was already approved, but I discovered a bug

Re: [PATCH (6/7)] More widening multiply-and-accumulate pattern matching

2011-07-07 Thread Richard Guenther
On Mon, Jul 4, 2011 at 4:31 PM, Andrew Stubbs a...@codesourcery.com wrote: On 28/06/11 16:30, Andrew Stubbs wrote: On 23/06/11 15:42, Andrew Stubbs wrote: This patch fixes the case where widening multiply-and-accumulate were not recognised because the multiplication itself is not actually

Re: [PATCH (6/7)] More widening multiply-and-accumulate pattern matching

2011-07-04 Thread Andrew Stubbs
On 28/06/11 16:30, Andrew Stubbs wrote: On 23/06/11 15:42, Andrew Stubbs wrote: This patch fixes the case where widening multiply-and-accumulate were not recognised because the multiplication itself is not actually widening. This can happen when you have DI + SI * SI - the multiplication will

Re: [PATCH (6/7)] More widening multiply-and-accumulate pattern matching

2011-06-28 Thread Andrew Stubbs
On 23/06/11 15:42, Andrew Stubbs wrote: This patch fixes the case where widening multiply-and-accumulate were not recognised because the multiplication itself is not actually widening. This can happen when you have DI + SI * SI - the multiplication will be done in SImode as a non-widening