Re: [PATCH 0/3] v3 of C++ template type diffing

2017-05-30 Thread David Malcolm
On Wed, 2017-05-10 at 09:34 -0400, Nathan Sidwell wrote: > On 05/09/2017 09:41 PM, David Malcolm wrote: > > On Tue, 2017-05-09 at 10:52 -0400, Nathan Sidwell wrote: > > > I split out the non-c++ bits into a separate patch. > > > > v3 of the patch kit is thus three parts: > > > > [1/3] Non-C++

Re: [PATCH 0/3] v3 of C++ template type diffing

2017-05-10 Thread Nathan Sidwell
On 05/09/2017 09:41 PM, David Malcolm wrote: On Tue, 2017-05-09 at 10:52 -0400, Nathan Sidwell wrote: I split out the non-c++ bits into a separate patch. v3 of the patch kit is thus three parts: [1/3] Non-C++ parts of template type diff printing I believe I can self-approve this part

[PATCH 0/3] v3 of C++ template type diffing

2017-05-09 Thread David Malcolm
On Tue, 2017-05-09 at 10:52 -0400, Nathan Sidwell wrote: > On 05/09/2017 10:07 AM, David Malcolm wrote: > > > > +static const char * > > +type_to_string_with_compare (tree type, tree peer, bool verbose, > > +bool show_color) > > +{ > > > + for (int idx = 0; idx <