Re: [PATCH 01/16] read-md.c: Add various cleanups to ~rtx_reader

2016-10-12 Thread Richard Sandiford
Sorry, haven't had time to read the full series yet, but: David Malcolm writes: > On Wed, 2016-10-05 at 17:51 +0200, Bernd Schmidt wrote: >> On 10/05/2016 06:14 PM, David Malcolm wrote: >> > The selftests for the RTL frontend require supporting multiple >> > reader instances being alive one after

Re: [PATCH 01/16] read-md.c: Add various cleanups to ~rtx_reader

2016-10-11 Thread David Malcolm
On Wed, 2016-10-05 at 17:51 +0200, Bernd Schmidt wrote: > On 10/05/2016 06:14 PM, David Malcolm wrote: > > The selftests for the RTL frontend require supporting multiple > > reader instances being alive one after another in-process, so > > this lack of cleanup would become a leak. > > > + /* Init

Re: [PATCH 01/16] read-md.c: Add various cleanups to ~rtx_reader

2016-10-05 Thread Bernd Schmidt
On 10/05/2016 06:14 PM, David Malcolm wrote: The selftests for the RTL frontend require supporting multiple reader instances being alive one after another in-process, so this lack of cleanup would become a leak. + /* Initialize global data. */ + obstack_init (&string_obstack); + ptr_locs =

[PATCH 01/16] read-md.c: Add various cleanups to ~rtx_reader

2016-10-05 Thread David Malcolm
Various global data items relating to reading .md files are currently initialized in rtx_reader::read_md_files, and are not cleaned up. The selftests for the RTL frontend require supporting multiple reader instances being alive one after another in-process, so this lack of cleanup would become a l