Re: [PATCH 04/N] Fix big memory leak in ix86_valid_target_attribute_p

2015-11-12 Thread Martin Liška
On 11/12/2015 04:58 PM, Ramana Radhakrishnan wrote: > > > On 12/11/15 15:52, Martin Liška wrote: >> On 11/12/2015 12:29 PM, Richard Biener wrote: >>> On Thu, Nov 12, 2015 at 11:03 AM, Martin Liška wrote: Hello. Following patch was a bit negotiated with Jakub and can save a huge am

Re: [PATCH 04/N] Fix big memory leak in ix86_valid_target_attribute_p

2015-11-12 Thread Ramana Radhakrishnan
On 12/11/15 15:52, Martin Liška wrote: > On 11/12/2015 12:29 PM, Richard Biener wrote: >> On Thu, Nov 12, 2015 at 11:03 AM, Martin Liška wrote: >>> Hello. >>> >>> Following patch was a bit negotiated with Jakub and can save a huge amount >>> of memory in cases >>> where target attributes are he

Re: [PATCH 04/N] Fix big memory leak in ix86_valid_target_attribute_p

2015-11-12 Thread Martin Liška
On 11/12/2015 12:29 PM, Richard Biener wrote: > On Thu, Nov 12, 2015 at 11:03 AM, Martin Liška wrote: >> Hello. >> >> Following patch was a bit negotiated with Jakub and can save a huge amount >> of memory in cases >> where target attributes are heavily utilized. >> >> Can bootstrap and survives

Re: [PATCH 04/N] Fix big memory leak in ix86_valid_target_attribute_p

2015-11-12 Thread Martin Liška
On 11/12/2015 12:33 PM, Bernd Schmidt wrote: > On 11/12/2015 12:29 PM, Richard Biener wrote: >> +static bool opts_obstack_initialized = false; >> + >> +/* Initialize opts_obstack if not initialized. */ >> + >> +void >> +init_opts_obstack (void) >> +{ >> + if (!opts_obstack_initialized) >> +{

Re: [PATCH 04/N] Fix big memory leak in ix86_valid_target_attribute_p

2015-11-12 Thread Bernd Schmidt
On 11/12/2015 12:29 PM, Richard Biener wrote: +static bool opts_obstack_initialized = false; + +/* Initialize opts_obstack if not initialized. */ + +void +init_opts_obstack (void) +{ + if (!opts_obstack_initialized) +{ + opts_obstack_initialized = true; + gcc_obstack_init (&opts_o

Re: [PATCH 04/N] Fix big memory leak in ix86_valid_target_attribute_p

2015-11-12 Thread Richard Biener
On Thu, Nov 12, 2015 at 11:03 AM, Martin Liška wrote: > Hello. > > Following patch was a bit negotiated with Jakub and can save a huge amount of > memory in cases > where target attributes are heavily utilized. > > Can bootstrap and survives regression tests on x86_64-linux-pc. > > Ready for trun

[PATCH 04/N] Fix big memory leak in ix86_valid_target_attribute_p

2015-11-12 Thread Martin Liška
Hello. Following patch was a bit negotiated with Jakub and can save a huge amount of memory in cases where target attributes are heavily utilized. Can bootstrap and survives regression tests on x86_64-linux-pc. Ready for trunk? Thanks, Martin >From ebb7bd3cf513dc437622868eddbed6c8f725a67c Mon S