Re: [PATCH 05/11] Handle const and varible modifiers for CodeView

2024-06-24 Thread Jeff Law
On 6/24/24 8:49 PM, Mark Harmstone wrote: On 24/6/24 04:39, Jeff Law wrote: So presumably you're freeing these objects elsewhere?  I see the free (custom_types), but I don' see where you free an subobjects.  Did I miss something? I'll go ahead and commit, but please double check for

Re: [PATCH 05/11] Handle const and varible modifiers for CodeView

2024-06-24 Thread Mark Harmstone
On 24/6/24 04:39, Jeff Law wrote: So presumably you're freeing these objects elsewhere?  I see the free (custom_types), but I don' see where you free an subobjects.  Did I miss something? I'll go ahead and commit, but please double check for memory leaks. Thanks Jeff. I just realized I

Re: [PATCH 05/11] Handle const and varible modifiers for CodeView

2024-06-23 Thread Jeff Law
On 6/17/24 6:17 PM, Mark Harmstone wrote: Translate DW_TAG_const_type and DW_TAG_volatile_type DIEs into LF_MODIFIER symbols. gcc/ * dwarf2codeview.cc (struct codeview_custom_type): Add lf_modifier to union. (write_cv_padding, write_lf_modifier):

[PATCH 05/11] Handle const and varible modifiers for CodeView

2024-06-17 Thread Mark Harmstone
Translate DW_TAG_const_type and DW_TAG_volatile_type DIEs into LF_MODIFIER symbols. gcc/ * dwarf2codeview.cc (struct codeview_custom_type): Add lf_modifier to union. (write_cv_padding, write_lf_modifier): New functions. (write_custom_types):