Re: [PATCH 1/12] implement -Wformat-diag to detect quoting and spelling issues in GCC diagnostics

2019-05-16 Thread Martin Liška
On 5/16/19 12:36 AM, Martin Sebor wrote: > On 5/15/19 8:50 AM, Martin Sebor wrote: >> On 5/15/19 5:40 AM, Martin Liška wrote: >>> On 5/14/19 11:31 PM, Martin Sebor wrote: The attached patch implements the -Wformat-diag warning to help find quoting, spelling, and other formatting issues 

Re: [PATCH 1/12] implement -Wformat-diag to detect quoting and spelling issues in GCC diagnostics

2019-05-15 Thread Martin Sebor
On 5/15/19 8:50 AM, Martin Sebor wrote: On 5/15/19 5:40 AM, Martin Liška wrote: On 5/14/19 11:31 PM, Martin Sebor wrote: The attached patch implements the -Wformat-diag warning to help find quoting, spelling, and other formatting issues in diagnostics issued by GCC. Just a general comment

Re: [PATCH 1/12] implement -Wformat-diag to detect quoting and spelling issues in GCC diagnostics

2019-05-15 Thread Martin Sebor
On 5/15/19 5:40 AM, Martin Liška wrote: On 5/14/19 11:31 PM, Martin Sebor wrote: The attached patch implements the -Wformat-diag warning to help find quoting, spelling, and other formatting issues in diagnostics issued by GCC. Just a general comment about this part. Wouldn't it make sense to

Re: [PATCH 1/12] implement -Wformat-diag to detect quoting and spelling issues in GCC diagnostics

2019-05-15 Thread Martin Liška
On 5/14/19 11:31 PM, Martin Sebor wrote: > The attached patch implements the -Wformat-diag warning to help find > quoting, spelling, and other formatting issues in diagnostics issued > by GCC. Just a general comment about this part. Wouldn't it make sense to use regex for some of the string

[PATCH 1/12] implement -Wformat-diag to detect quoting and spelling issues in GCC diagnostics

2019-05-14 Thread Martin Sebor
The attached patch implements the -Wformat-diag warning to help find quoting, spelling, and other formatting issues in diagnostics issued by GCC. Martin gcc/c-family/ChangeLog: * c-common.h (GCC_DIAG_STYLE): Adjust. (GCC_DIAG_RAW_STYLE): New macro. c-format.c