Re: [PATCH 1/2] PR c/65403 - Ignore -Wno-error=

2019-06-25 Thread Alex Henrie
On Wed, Jun 19, 2019 at 11:52 AM Jeff Law wrote: > > On 3/18/19 8:46 PM, Alex Henrie wrote: > > From: Manuel López-Ibáñez > > > > * opts.c: Ignore -Wno-error= except if there are > > other diagnostics. > That's not a complete ChangeLog entry. Each file/function changed > should be mentioned. So

Re: [PATCH 1/2] PR c/65403 - Ignore -Wno-error=

2019-06-19 Thread Jeff Law
On 3/18/19 8:46 PM, Alex Henrie wrote: > From: Manuel López-Ibáñez > > * opts.c: Ignore -Wno-error= except if there are > other diagnostics. That's not a complete ChangeLog entry. Each file/function changed should be mentioned. Something like this: * opts-common.c (ignored_wnoerror_opt

Re: [PATCH 1/2] PR c/65403 - Ignore -Wno-error=

2019-03-19 Thread Alex Henrie
On Tue, Mar 19, 2019 at 11:26 AM Martin Sebor wrote: > > Please remember to quote the command line options in the message > (same as in the error below): I'll send a new version. Thanks for the feedback! -Alex

Re: [PATCH 1/2] PR c/65403 - Ignore -Wno-error=

2019-03-19 Thread Martin Sebor
On 3/18/19 8:46 PM, Alex Henrie wrote: From: Manuel López-Ibáñez * opts.c: Ignore -Wno-error= except if there are other diagnostics. --- gcc/opts-common.c | 2 ++ gcc/opts-global.c | 10 +++--- gcc/opts.c| 5 - gcc/opts.h| 2 ++ 4 files changed, 15 insertions(+)

[PATCH 1/2] PR c/65403 - Ignore -Wno-error=

2019-03-18 Thread Alex Henrie
From: Manuel López-Ibáñez * opts.c: Ignore -Wno-error= except if there are other diagnostics. --- gcc/opts-common.c | 2 ++ gcc/opts-global.c | 10 +++--- gcc/opts.c| 5 - gcc/opts.h| 2 ++ 4 files changed, 15 insertions(+), 4 deletions(-) diff --git a/gcc/opts-common