Re: [PATCH 1/2] PR94600: fix volatile access to the whole of a compound object.

2020-07-07 Thread Richard Biener via Gcc-patches
On Tue, Jul 7, 2020 at 6:03 AM Hans-Peter Nilsson via Gcc-patches wrote: > > The store to the whole of each volatile object was picked apart > like there had been an individual assignment to each of the > fields. Reads were added as part of that; see PR for details. > The reads from volatile memo

Re: [PATCH 1/2] PR94600: fix volatile access to the whole of a compound object.

2020-07-06 Thread Hans-Peter Nilsson via Gcc-patches
> From: Hans-Peter Nilsson > Date: Tue, 7 Jul 2020 06:01:37 +0200 > gcc: > PR middle-end/94600 > * expr.c (expand_constructor): Make a temporary also if we're > storing to volatile memory. Oops, I dropped attribution here, but this patch is by Richard Biener (modulo the comment

[PATCH 1/2] PR94600: fix volatile access to the whole of a compound object.

2020-07-06 Thread Hans-Peter Nilsson via Gcc-patches
The store to the whole of each volatile object was picked apart like there had been an individual assignment to each of the fields. Reads were added as part of that; see PR for details. The reads from volatile memory were a clear bug; individual stores questionable. A separate patch clarifies the