[PATCH 1/2] c++: Replay errors during diagnosis of constraint satisfaction failures

2020-03-09 Thread Patrick Palka
This patch adds a new flag -fconcepts-diagnostics-depth to the C++ frontend which controls how deeply we replay errors when diagnosing a constraint satisfaction failure. The default is -fconcepts-diagnostics-depth=1 which diagnoses only the topmost constraint satisfaction failure and is consistent

Re: [PATCH 1/2] c++: Replay errors during diagnosis of constraint satisfaction failures

2020-03-11 Thread Jason Merrill via Gcc-patches
On 3/9/20 6:23 PM, Patrick Palka wrote: This patch adds a new flag -fconcepts-diagnostics-depth to the C++ frontend which controls how deeply we replay errors when diagnosing a constraint satisfaction failure. The default is -fconcepts-diagnostics-depth=1 which diagnoses only the topmost constra

Re: [PATCH 1/2] c++: Replay errors during diagnosis of constraint satisfaction failures

2020-03-11 Thread Patrick Palka via Gcc-patches
On Wed, 11 Mar 2020, Jason Merrill wrote: > On 3/9/20 6:23 PM, Patrick Palka wrote: > > This patch adds a new flag -fconcepts-diagnostics-depth to the C++ frontend > > which controls how deeply we replay errors when diagnosing a constraint > > satisfaction failure. The default is -fconcepts-diagn

Re: [PATCH 1/2] c++: Replay errors during diagnosis of constraint satisfaction failures

2020-03-15 Thread Martin Sebor via Gcc-patches
On 3/11/20 4:18 PM, Patrick Palka via Gcc-patches wrote: ... Hmm, like this? This version introduces a new static member function diagnosing_failed_constraint::replay_errors_p that checks current_constraint_diagnosis_depth, and also sets max_depth_exceeded_p when appropriate. ... Just one sma

Re: [PATCH 1/2] c++: Replay errors during diagnosis of constraint satisfaction failures

2020-03-16 Thread Patrick Palka via Gcc-patches
Hi Martin, On Sun, 15 Mar 2020, Martin Sebor wrote: > On 3/11/20 4:18 PM, Patrick Palka via Gcc-patches wrote: > ... > > Hmm, like this? This version introduces a new static member function > > diagnosing_failed_constraint::replay_errors_p that checks > > current_constraint_diagnosis_depth, and

Re: [PATCH 1/2] c++: Replay errors during diagnosis of constraint satisfaction failures

2020-03-26 Thread Patrick Palka via Gcc-patches
On Mon, 16 Mar 2020, Patrick Palka wrote: > Hi Martin, > > On Sun, 15 Mar 2020, Martin Sebor wrote: > > > On 3/11/20 4:18 PM, Patrick Palka via Gcc-patches wrote: > > ... > > > Hmm, like this? This version introduces a new static member function > > > diagnosing_failed_constraint::replay_errors

Re: [PATCH 1/2] c++: Replay errors during diagnosis of constraint satisfaction failures

2020-03-27 Thread Jason Merrill via Gcc-patches
On 3/27/20 12:17 AM, Patrick Palka wrote: On Mon, 16 Mar 2020, Patrick Palka wrote: Hi Martin, On Sun, 15 Mar 2020, Martin Sebor wrote: On 3/11/20 4:18 PM, Patrick Palka via Gcc-patches wrote: ... Hmm, like this? This version introduces a new static member function diagnosing_failed_constr