Re: [PATCH 1/4] Clean up of new format of -falign-FOO.

2018-07-22 Thread Rainer Orth
Hi Gerald, > On Sun, 22 Jul 2018, Gerald Pfeifer wrote: >> With clang version 3.4 (system compiler on FreeBSD 10.x) this is >> even a hard error and GCC failed to build. So thanks for fixing >> this, Martin! > > Unfortunately it appears there was another bootstrap failure hidden > behind that one

Re: [PATCH 1/4] Clean up of new format of -falign-FOO.

2018-07-22 Thread Gerald Pfeifer
On Sun, 22 Jul 2018, Gerald Pfeifer wrote: > With clang version 3.4 (system compiler on FreeBSD 10.x) this is > even a hard error and GCC failed to build. So thanks for fixing > this, Martin! Unfortunately it appears there was another bootstrap failure hidden behind that one: In file included f

Re: [PATCH 1/4] Clean up of new format of -falign-FOO.

2018-07-22 Thread Gerald Pfeifer
On Wed, 18 Jul 2018, Martin Sebor wrote: > I'm seeing lots of warnings for this file: > > /ssd/src/gcc/svn/gcc/align.h:53:32: warning: extended initializer lists only > available with -std=c++11 or -std=gnu++11 With clang version 3.4 (system compiler on FreeBSD 10.x) this is even a hard error and

Re: [PATCH 1/4] Clean up of new format of -falign-FOO.

2018-07-18 Thread Martin Sebor
On 07/04/2018 04:23 AM, marxin wrote: gcc/ChangeLog: 2018-07-11 Martin Liska * align.h: New file. Martin, I'm seeing lots of warnings for this file: /ssd/src/gcc/svn/gcc/align.h:53:32: warning: extended initializer lists only available with -std=c++11 or -std=gnu++11 The code

Re: [PATCH 1/4] Clean up of new format of -falign-FOO.

2018-07-18 Thread Martin Liška
On 07/18/2018 05:52 AM, Michael Collison wrote: > Hi Martin, > > Your alignment patch breaks the arm port. In the file arm.c, function > 'get_label_padding' the code uses: > > static HOST_WIDE_INT > get_label_padding (rtx label) > { > HOST_WIDE_INT align, min_insn_size; > > align = 1 << lab

Re: [PATCH 1/4] Clean up of new format of -falign-FOO.

2018-07-17 Thread Michael Collison
Hi Martin, Your alignment patch breaks the arm port. In the file arm.c, function 'get_label_padding' the code uses: static HOST_WIDE_INT get_label_padding (rtx label) { HOST_WIDE_INT align, min_insn_size; align = 1 << label_to_alignment (label); min_insn_size = TARGET_THUMB ? 2 : 4; ret

Re: [PATCH 1/4] Clean up of new format of -falign-FOO.

2018-07-17 Thread Martin Liška
On 07/16/2018 11:24 PM, Jeff Law wrote: > All 4 patches in this kit are fine after you fix the minor issue Pat > reported with patch #1 on ppc. > > Jeff Thank you Jeff for the trust. I fixed the minor issue and installed the patch set. Martin

Re: [PATCH 1/4] Clean up of new format of -falign-FOO.

2018-07-16 Thread Jeff Law
On 07/04/2018 04:23 AM, marxin wrote: > gcc/ChangeLog: > > 2018-07-11 Martin Liska > > * align.h: New file. > * config/alpha/alpha.c (alpha_align_insns_1): Use align_functions > directly. > * config/i386/i386.c (ix86_avoid_jump_mispredicts): Use new return type > align

Re: [PATCH 1/4] Clean up of new format of -falign-FOO.

2018-07-16 Thread Pat Haugen
testsuite/gcc.target/powerpc/loop_align.c fails with this patch. It just needs a simple tweak to the scan-assembler line since we're no longer generating the ",,31" portion on the .p2align. -Pat

[PATCH 1/4] Clean up of new format of -falign-FOO.

2018-07-16 Thread marxin
gcc/ChangeLog: 2018-07-11 Martin Liska * align.h: New file. * config/alpha/alpha.c (alpha_align_insns_1): Use align_functions directly. * config/i386/i386.c (ix86_avoid_jump_mispredicts): Use new return type align_flags of label_to_alignment. * config/