Re: [PATCH 1/4] Make SRA scalarize constant-pool loads

2016-02-08 Thread Jeff Law
On 01/27/2016 05:14 PM, David Edelsohn wrote: On Wed, Jan 27, 2016 at 6:36 PM, Jeff Law wrote: On 01/27/2016 12:39 PM, David Edelsohn wrote: The new sra-17.c and sra-18.c tests fail on AIX because the regex is too restrictive -- AIX labels don't have exactly the same format.

Re: [PATCH 1/4] Make SRA scalarize constant-pool loads

2016-01-27 Thread Jeff Law
On 01/27/2016 12:39 PM, David Edelsohn wrote: The new sra-17.c and sra-18.c tests fail on AIX because the regex is too restrictive -- AIX labels don't have exactly the same format. On AIX, the labels in the dumps look like "LC..0" instead of ".LC0". This patch adds "*" and ".*" so that the "."

Re: [PATCH 1/4] Make SRA scalarize constant-pool loads

2016-01-27 Thread David Edelsohn
On Wed, Jan 27, 2016 at 6:36 PM, Jeff Law wrote: > On 01/27/2016 12:39 PM, David Edelsohn wrote: >> >> The new sra-17.c and sra-18.c tests fail on AIX because the regex is >> too restrictive -- AIX labels don't have exactly the same format. On >> AIX, the labels in the dumps

Re: [PATCH 1/4] Make SRA scalarize constant-pool loads

2016-01-27 Thread David Edelsohn
The new sra-17.c and sra-18.c tests fail on AIX because the regex is too restrictive -- AIX labels don't have exactly the same format. On AIX, the labels in the dumps look like "LC..0" instead of ".LC0". This patch adds "*" and ".*" so that the "." prepended to LC is optional and to allow

Re: [PATCH 1/4] Make SRA scalarize constant-pool loads

2016-01-18 Thread Richard Biener
On Fri, Jan 15, 2016 at 11:27 AM, Alan Lawrence wrote: > On 24/12/15 11:53, Alan Lawrence wrote: >> >> Here's a new version that fixes the gcc.dg/guality/pr54970.c failures seen >> on >> aarch64 and powerpc64. Prior to SRA handling constant pool decls, >>

Re: [PATCH 1/4] Make SRA scalarize constant-pool loads

2016-01-15 Thread Alan Lawrence
On 24/12/15 11:53, Alan Lawrence wrote: Here's a new version that fixes the gcc.dg/guality/pr54970.c failures seen on aarch64 and powerpc64. Prior to SRA handling constant pool decls, -fdump-tree-esra-details (at -O1 -g) had shown: : a = *.LC0; # DEBUG a$0 => MEM[(int[3] *)&*.LC0]

Re: [PATCH 1/4] Make SRA scalarize constant-pool loads

2016-01-04 Thread Alan Lawrence
On 24/12/15 11:53, Alan Lawrence wrote: Here's a new version that fixes the gcc.dg/guality/pr54970.c failures seen on aarch64 and powerpc64. [snip] This also fixes a bunch of other guality tests on AArch64 that were failing prior to the patch series, and another bunch on PowerPC64 (bigendian

Re: [PATCH 1/4] Make SRA scalarize constant-pool loads

2015-12-24 Thread Alan Lawrence
Here's a new version that fixes the gcc.dg/guality/pr54970.c failures seen on aarch64 and powerpc64. Prior to SRA handling constant pool decls, -fdump-tree-esra-details (at -O1 -g) had shown: : a = *.LC0; # DEBUG a$0 => MEM[(int[3] *)&*.LC0] a$4_3 = MEM[(int[3] *)&*.LC0 + 4B]; # DEBUG

[PATCH 1/4] Make SRA scalarize constant-pool loads

2015-12-21 Thread Alan Lawrence
This is the same as the version conditionally approved near the end of stage 1 https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01948.html, plus the requested comment and a couple of testcases for platforms where the constants are pushed into the constant pool. (I didn't commit this at the time