Re: Impact of gimple renamings on reviews (was Re: [PATCH 16/89] tree-ssa-loop-ivopts.c: use gimple_phi in a few places)

2014-05-09 Thread Jeff Law
On 05/09/14 12:47, David Malcolm wrote: Jeff: thanks. Note that I'm currently working on a grand renaming, as per the subthread here: http://gcc.gnu.org/ml/gcc-patches/2014-05/msg00346.html so that all of these will be "gphi *" rather than "gimple_phi", with analogous change to the other class

Impact of gimple renamings on reviews (was Re: [PATCH 16/89] tree-ssa-loop-ivopts.c: use gimple_phi in a few places)

2014-05-09 Thread David Malcolm
On Fri, 2014-05-09 at 12:34 -0600, Jeff Law wrote: > On 04/21/14 10:56, David Malcolm wrote: > > gcc/ > > * tree-ssa-loop-ivopts.c (determine_biv_step): Require a gimple_phi. > > (find_bivs): Convert local "phi" into a gimple_phi. > > (mark_bivs): Likewise. > OK when prerequisites have

Re: [PATCH 16/89] tree-ssa-loop-ivopts.c: use gimple_phi in a few places

2014-05-09 Thread Jeff Law
On 04/21/14 10:56, David Malcolm wrote: gcc/ * tree-ssa-loop-ivopts.c (determine_biv_step): Require a gimple_phi. (find_bivs): Convert local "phi" into a gimple_phi. (mark_bivs): Likewise. OK when prerequisites have gone in. Actually that's true for #17 & #18 as well. j

[PATCH 16/89] tree-ssa-loop-ivopts.c: use gimple_phi in a few places

2014-04-21 Thread David Malcolm
gcc/ * tree-ssa-loop-ivopts.c (determine_biv_step): Require a gimple_phi. (find_bivs): Convert local "phi" into a gimple_phi. (mark_bivs): Likewise. --- gcc/tree-ssa-loop-ivopts.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gcc/tree-ssa-loop-i